2019-02-11 20:38:55

by Gustavo A. R. Silva

Subject: [PATCH] gpio: sprd: Add missing break in switch statement

Fix the following warning by adding a missing break:

drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (flow_type) {
^~~~~~
drivers/gpio/gpio-eic-sprd.c:435:2: note: here
default:
^~~~~~~

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/gpio/gpio-eic-sprd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index e41223c05f6e..f0223cee9774 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -432,6 +432,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
default:
return -ENOTSUPP;
}
+ break;
default:
dev_err(chip->parent, "Unsupported EIC type.\n");
return -ENOTSUPP;
--
2.20.1

2019-02-12 02:08:14

by Baolin Wang

Subject: Re: [PATCH] gpio: sprd: Add missing break in switch statement

Hi Gustavo,

On Tue, 12 Feb 2019 at 02:50, Gustavo A. R. Silva
<[email protected]> wrote:
>
> Fix the following warning by adding a missing break:
>
> drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> switch (flow_type) {
> ^~~~~~
> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
> default:
> ^~~~~~~
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Thanks for fixing my mistake.
Reviewed-by: Baolin Wang <[email protected]>

> ---
> drivers/gpio/gpio-eic-sprd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index e41223c05f6e..f0223cee9774 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -432,6 +432,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
> default:
> return -ENOTSUPP;
> }
> + break;
> default:
> dev_err(chip->parent, "Unsupported EIC type.\n");
> return -ENOTSUPP;
> --
> 2.20.1
>


--
Baolin Wang
Best Regards

2019-02-12 02:13:25

by Gustavo A. R. Silva

Subject: Re: [PATCH] gpio: sprd: Add missing break in switch statement

Hi Baolin,

On 2/11/19 8:07 PM, Baolin Wang wrote:
> Hi Gustavo,
>
> On Tue, 12 Feb 2019 at 02:50, Gustavo A. R. Silva
> <[email protected]> wrote:
>>
>> Fix the following warning by adding a missing break:
>>
>> drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
>> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> switch (flow_type) {
>> ^~~~~~
>> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
>> default:
>> ^~~~~~~
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>
> Thanks for fixing my mistake.
> Reviewed-by: Baolin Wang <[email protected]>
>

Glad to help. :)

Thanks
--
Gustavo

2019-02-13 13:34:35

by Linus Walleij

Subject: Re: [PATCH] gpio: sprd: Add missing break in switch statement

On Mon, Feb 11, 2019 at 7:50 PM Gustavo A. R. Silva
<[email protected]> wrote:

> Fix the following warning by adding a missing break:
>
> drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> switch (flow_type) {
> ^~~~~~
> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
> default:
> ^~~~~~~
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Patch applied with Baolin's review tag.

Yours,
Linus Walleij