2021-08-18 22:19:42

by Gustavo A. R. Silva

Subject: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang

Fix the following fallthrough warnings:

fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

This helps with the ongoing efforts to globally enable
-Wimplicit-fallthrough for Clang.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
fs/ntfs3/index.c | 1 +
fs/ntfs3/inode.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index 6aa9540ece47..76eae60b7fce 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
default:
break;
}
+ break;
default:
break;
}
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index bf51e294432e..a573c6e98cb8 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
switch (err) {
case 0:
drop_nlink(inode);
+ break;
case -ENOTEMPTY:
case -ENOSPC:
case -EROFS:
--
2.27.0

2021-08-18 23:30:13

by Nathan Chancellor

Subject: Re: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang

On 8/18/2021 3:21 PM, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warnings:
>
> fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>
> This helps with the ongoing efforts to globally enable
> -Wimplicit-fallthrough for Clang.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> fs/ntfs3/index.c | 1 +
> fs/ntfs3/inode.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6aa9540ece47..76eae60b7fce 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
> default:
> break;
> }
> + break;
> default:
> break;
> }
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index bf51e294432e..a573c6e98cb8 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
> switch (err) {
> case 0:
> drop_nlink(inode);
> + break;
> case -ENOTEMPTY:
> case -ENOSPC:
> case -EROFS:
>

2021-08-27 16:28:28

by Konstantin Komarov

Subject: RE: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang

> From: Gustavo A. R. Silva <[email protected]>
> Sent: Thursday, August 19, 2021 1:22 AM
> To: Konstantin Komarov <[email protected]>
> Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>; linux-
> [email protected]
> Subject: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang
>
> Fix the following fallthrough warnings:
>
> fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>
> This helps with the ongoing efforts to globally enable
> -Wimplicit-fallthrough for Clang.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> fs/ntfs3/index.c | 1 +
> fs/ntfs3/inode.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6aa9540ece47..76eae60b7fce 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
> default:
> break;
> }
> + break;
> default:
> break;
> }
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index bf51e294432e..a573c6e98cb8 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
> switch (err) {
> case 0:
> drop_nlink(inode);
> + break;
> case -ENOTEMPTY:
> case -ENOSPC:
> case -EROFS:
> --
> 2.27.0

Hi Gustavo, thank you. Picked into ntfs3 tree.

Best regards.