2018-11-09 16:52:48

by Sabyasachi Gupta

Subject: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent

Replaced dma_alloc_coherent + memset with dma_zalloc_coherent

Signed-off-by: Sabyasachi Gupta <[email protected]>
---
drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
index dcb4bba..df4f7a3 100644
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
@@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
if (!wq->sq)
goto err3;

- wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
+ wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
depth * sizeof(union t3_wr),
&(wq->dma_addr), GFP_KERNEL);
if (!wq->queue)
goto err4;

- memset(wq->queue, 0, depth * sizeof(union t3_wr));
dma_unmap_addr_set(wq, mapping, wq->dma_addr);
wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
if (!kernel_domain)
--
2.7.4

2018-11-12 15:30:34

by Steve Wise

Subject: Re: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent

On 11/9/2018 10:50 AM, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> index dcb4bba..df4f7a3 100644
> --- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
> +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> @@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
> if (!wq->sq)
> goto err3;
>
> - wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> + wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> depth * sizeof(union t3_wr),
> &(wq->dma_addr), GFP_KERNEL);
> if (!wq->queue)
> goto err4;
>
> - memset(wq->queue, 0, depth * sizeof(union t3_wr));
> dma_unmap_addr_set(wq, mapping, wq->dma_addr);
> wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
> if (!kernel_domain)
>

Acked-by: Steve Wise <[email protected]>

2018-11-12 15:32:45

by Steve Wise

Subject: Re: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent

On 11/9/2018 10:50 AM, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> index dcb4bba..df4f7a3 100644
> --- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
> +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> @@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
> if (!wq->sq)
> goto err3;
>
> - wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> + wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> depth * sizeof(union t3_wr),
> &(wq->dma_addr), GFP_KERNEL);
> if (!wq->queue)
> goto err4;
>
> - memset(wq->queue, 0, depth * sizeof(union t3_wr));
> dma_unmap_addr_set(wq, mapping, wq->dma_addr);
> wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
> if (!kernel_domain)
>

Acked-by: Steve Wise <[email protected]>

2018-11-22 09:28:45

by Jason Gunthorpe

Subject: Re: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent

On Fri, Nov 09, 2018 at 10:20:29PM +0530, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> Acked-by: Steve Wise <[email protected]>
> Acked-by: Steve Wise <[email protected]>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next

Thanks,
Jason