2020-01-22 10:48:27

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH] of: irq: Export of_msi_get_domain

From: Matthias Brugger <[email protected]>

Export of_mis_get_domain to enable it for users from outside.

Signed-off-by: Matthias Brugger <[email protected]>
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Peter Ujfalusi <[email protected]>
---
Hi Rob, Matthias,

I needed to resort to remove module build support for the new ringacc UDMA
drivers (now they are in next-20200122) due to the fact that of_msi_get_domain()
is not having the EXPORT_SYMBOL_GPL() which is used by both drivers.

I have found this old patch in lkml, but can not see the history of why it is
not applied.

Regards,
Peter

drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index a296eaf52a5b..73017506ef00 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -673,6 +673,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,

return NULL;
}
+EXPORT_SYMBOL_GPL(of_msi_get_domain);

/**
* of_msi_configure - Set the msi_domain field of a device
--
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


2020-01-22 11:05:15

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] of: irq: Export of_msi_get_domain



On 22/01/2020 11:47, Peter Ujfalusi wrote:
> From: Matthias Brugger <[email protected]>
>
> Export of_mis_get_domain to enable it for users from outside.
>
> Signed-off-by: Matthias Brugger <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---
> Hi Rob, Matthias,
>
> I needed to resort to remove module build support for the new ringacc UDMA
> drivers (now they are in next-20200122) due to the fact that of_msi_get_domain()
> is not having the EXPORT_SYMBOL_GPL() which is used by both drivers.
>
> I have found this old patch in lkml, but can not see the history of why it is
> not applied.

The series it was part of was abandoned. The itself shouldn't have an issue.

Regards,
Matthias

>
> Regards,
> Peter
>
> drivers/of/irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index a296eaf52a5b..73017506ef00 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -673,6 +673,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
>
> return NULL;
> }
> +EXPORT_SYMBOL_GPL(of_msi_get_domain);
>
> /**
> * of_msi_configure - Set the msi_domain field of a device
>