2019-06-19 13:12:33

by Arnd Bergmann

Subject: [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4

When building a multiplatform kernel that includes armv4 support,
the default target CPU does not support the blx instruction,
which leads to a build failure:

arch/arm/mach-davinci/sleep.S: Assembler messages:
arch/arm/mach-davinci/sleep.S:56: Error: selected processor does not support `blx ip' in ARM mode

Add a .arch statement in the sources to make this file build.

Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/arm/mach-davinci/sleep.S | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/sleep.S b/arch/arm/mach-davinci/sleep.S
index 05d03f09ff54..71262dcdbca3 100644
--- a/arch/arm/mach-davinci/sleep.S
+++ b/arch/arm/mach-davinci/sleep.S
@@ -24,6 +24,7 @@
#define DEEPSLEEP_SLEEPENABLE_BIT BIT(31)

.text
+ .arch armv5te
/*
* Move DaVinci into deep sleep state
*
--
2.20.0

2019-06-19 14:55:14

by Sekhar Nori

Subject: Re: [PATCH] [RESEND] ARM: davinci: fix sleep.S build error on ARMv4

Hi Arnd,

On 19/06/19 6:41 PM, Arnd Bergmann wrote:
> When building a multiplatform kernel that includes armv4 support,
> the default target CPU does not support the blx instruction,
> which leads to a build failure:
>
> arch/arm/mach-davinci/sleep.S: Assembler messages:
> arch/arm/mach-davinci/sleep.S:56: Error: selected processor does not support `blx ip' in ARM mode
>
> Add a .arch statement in the sources to make this file build.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Tested on OMAP-L138 LCDK board with suspend-resume.

Assuming you will pick this directly:

Acked-by: Sekhar Nori <[email protected]>

Regards,
Sekhar