2020-08-28 19:25:59

by Krzysztof Kozlowski

Subject: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

The PMIC node can be a clock provider (for its 32 kHz clock) and authors
of imx8mq-librem5-devkit.dts apparently wanted this because they added
input clock and clock-output-names.

Add necessary clock-cells to the PMIC node.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index 377591a0e6e9..40b43625f20f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -285,6 +285,7 @@
pinctrl-0 = <&pinctrl_pmic>;
clocks = <&pmic_osc>;
clock-names = "osc";
+ #clock-cells = <0>;
clock-output-names = "pmic_clk";
interrupt-parent = <&gpio1>;
interrupts = <3 GPIO_ACTIVE_LOW>;
--
2.17.1

2020-08-29 11:48:51

by Martin Kepplinger

Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

On 28.08.20 21:22, Krzysztof Kozlowski wrote:
> The PMIC node can be a clock provider (for its 32 kHz clock) and authors
> of imx8mq-librem5-devkit.dts apparently wanted this because they added
> input clock and clock-output-names.
>
> Add necessary clock-cells to the PMIC node.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 377591a0e6e9..40b43625f20f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -285,6 +285,7 @@
> pinctrl-0 = <&pinctrl_pmic>;
> clocks = <&pmic_osc>;
> clock-names = "osc";
> + #clock-cells = <0>;
> clock-output-names = "pmic_clk";
> interrupt-parent = <&gpio1>;
> interrupts = <3 GPIO_ACTIVE_LOW>;
>

Hi Krzysztof,

Reviewed-and-tested-by: Martin Kepplinger <[email protected]>

thanks for reviewing,

martin

2020-08-31 05:58:39

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

On Fri, Aug 28, 2020 at 09:22:28PM +0200, Krzysztof Kozlowski wrote:
> The PMIC node can be a clock provider (for its 32 kHz clock) and authors
> of imx8mq-librem5-devkit.dts apparently wanted this because they added
> input clock and clock-output-names.
>
> Add necessary clock-cells to the PMIC node.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied, thanks.