2023-07-26 15:58:58

by Arnd Bergmann

Subject: [PATCH] ata: pata_ns87415: mark ns87560_tf_read static

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

drivers/parport/parport_gsc.c: At top level:
drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]

There are no other references to this, so just make it static.

Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/ata/pata_ns87415.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
index d60e1f69d7b02..c697219a61a2d 100644
--- a/drivers/ata/pata_ns87415.c
+++ b/drivers/ata/pata_ns87415.c
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
* LOCKING:
* Inherited from caller.
*/
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
{
struct ata_ioports *ioaddr = &ap->ioaddr;

--
2.39.2

2023-07-26 17:21:50

by Sergey Shtylyov

Subject: Re: [PATCH] ata: pata_ns87415: mark ns87560_tf_read static

On 7/26/23 6:10 PM, Arnd Bergmann wrote:

> From: Arnd Bergmann <[email protected]>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/parport/parport_gsc.c: At top level:
> drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]

Wrong pasting? :-)

> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Signed-off-by: Arnd Bergmann <[email protected]>

With the messages fixed:

Reviewed-by: Sergey Shtylyov <[email protected]>

[...]

MBR, Sergey

2023-07-27 12:49:54

by Serge Semin

Subject: Re: [PATCH] ata: pata_ns87415: mark ns87560_tf_read static

On Wed, Jul 26, 2023 at 05:10:23PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/parport/parport_gsc.c: At top level:
> drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]
>
> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Signed-off-by: Arnd Bergmann <[email protected]>

Looking good.
Reviewed-by: Serge Semin <[email protected]>

-Serge(y)

> ---
> drivers/ata/pata_ns87415.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
> index d60e1f69d7b02..c697219a61a2d 100644
> --- a/drivers/ata/pata_ns87415.c
> +++ b/drivers/ata/pata_ns87415.c
> @@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
> * LOCKING:
> * Inherited from caller.
> */
> -void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> +static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> {
> struct ata_ioports *ioaddr = &ap->ioaddr;
>
> --
> 2.39.2
>