2020-11-30 12:25:47

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] PCI: iproc: Add fixes to pcie iproc

On Thu, Oct 01, 2020 at 11:30:51AM +0530, Srinath Mannam wrote:
> This patch series contains fixes and improvements to pcie iproc driver.
>
> This patch set is based on Linux-5.9.0-rc2.
>
> Changes from v2:
> - Addressed Bjorn's review comments
> - Corrected subject line and commit message of Patches 1 and 2.
>
> Changes from v1:
> - Addressed Bjorn's review comments
> - pcie_print_link_status is used to print Link information.
> - Added IARR1/IMAP1 window map definition.
>
> Bharat Gooty (1):
> PCI: iproc: Fix out-of-bound array accesses
>
> Roman Bacik (1):
> PCI: iproc: Invalidate correct PAXB inbound windows
>
> Srinath Mannam (1):
> PCI: iproc: Display PCIe Link information
>
> drivers/pci/controller/pcie-iproc.c | 29 ++++++++++++++++++++++-------
> 1 file changed, 22 insertions(+), 7 deletions(-)

I need Ray a/o Scott ACK to proceed.

Thanks,
Lorenzo

2020-11-30 17:42:58

by Scott Branden

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] PCI: iproc: Add fixes to pcie iproc



On 2020-11-30 4:19 a.m., Lorenzo Pieralisi wrote:
> On Thu, Oct 01, 2020 at 11:30:51AM +0530, Srinath Mannam wrote:
>> This patch series contains fixes and improvements to pcie iproc driver.
>>
>> This patch set is based on Linux-5.9.0-rc2.
>>
>> Changes from v2:
>> - Addressed Bjorn's review comments
>> - Corrected subject line and commit message of Patches 1 and 2.
>>
>> Changes from v1:
>> - Addressed Bjorn's review comments
>> - pcie_print_link_status is used to print Link information.
>> - Added IARR1/IMAP1 window map definition.
>>
>> Bharat Gooty (1):
>> PCI: iproc: Fix out-of-bound array accesses
>>
>> Roman Bacik (1):
>> PCI: iproc: Invalidate correct PAXB inbound windows
>>
>> Srinath Mannam (1):
>> PCI: iproc: Display PCIe Link information
>>
>> drivers/pci/controller/pcie-iproc.c | 29 ++++++++++++++++++++++-------
>> 1 file changed, 22 insertions(+), 7 deletions(-)
> I need Ray a/o Scott ACK to proceed.
Let's see if Ray has anything to add.

Acked-by: Scott Branden <[email protected]>
>
> Thanks,
> Lorenzo


Attachments:
smime.p7s (4.07 kB)
S/MIME Cryptographic Signature

2020-11-30 17:58:41

by Ray Jui

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] PCI: iproc: Add fixes to pcie iproc



On 11/30/2020 9:39 AM, Scott Branden wrote:
>
>
> On 2020-11-30 4:19 a.m., Lorenzo Pieralisi wrote:
>> On Thu, Oct 01, 2020 at 11:30:51AM +0530, Srinath Mannam wrote:
>>> This patch series contains fixes and improvements to pcie iproc driver.
>>>
>>> This patch set is based on Linux-5.9.0-rc2.
>>>
>>> Changes from v2:
>>> - Addressed Bjorn's review comments
>>> - Corrected subject line and commit message of Patches 1 and 2.
>>>
>>> Changes from v1:
>>> - Addressed Bjorn's review comments
>>> - pcie_print_link_status is used to print Link information.
>>> - Added IARR1/IMAP1 window map definition.
>>>
>>> Bharat Gooty (1):
>>> PCI: iproc: Fix out-of-bound array accesses
>>>
>>> Roman Bacik (1):
>>> PCI: iproc: Invalidate correct PAXB inbound windows
>>>
>>> Srinath Mannam (1):
>>> PCI: iproc: Display PCIe Link information
>>>
>>> drivers/pci/controller/pcie-iproc.c | 29 ++++++++++++++++++++++-------
>>> 1 file changed, 22 insertions(+), 7 deletions(-)
>> I need Ray a/o Scott ACK to proceed.
> Let's see if Ray has anything to add.
>
> Acked-by: Scott Branden <[email protected]>

I reviewed them internally before they were sent out. I just reviewed
them again and yes they look fine to me.

1/3 and 2/3 are critical fixes for kernel crash and boot up issue in
corner cases (Fixes tag already applied and should be picked up by LTS
once merged).

Thanks.

Acked-by: Ray Jui <[email protected]>

>>
>> Thanks,
>> Lorenzo
>


Attachments:
smime.p7s (4.05 kB)
S/MIME Cryptographic Signature

2020-11-30 18:35:39

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] PCI: iproc: Add fixes to pcie iproc

On Thu, 1 Oct 2020 11:30:51 +0530, Srinath Mannam wrote:
> This patch series contains fixes and improvements to pcie iproc driver.
>
> This patch set is based on Linux-5.9.0-rc2.
>
> Changes from v2:
> - Addressed Bjorn's review comments
> - Corrected subject line and commit message of Patches 1 and 2.
>
> [...]

Applied to pci/iproc, thanks!

[1/3] PCI: iproc: Fix out-of-bound array accesses
https://git.kernel.org/lpieralisi/pci/c/a3ff529f5d
[2/3] PCI: iproc: Invalidate correct PAXB inbound windows
https://git.kernel.org/lpieralisi/pci/c/89bbcaac3d
[3/3] PCI: iproc: Enhance PCIe Link information display
https://git.kernel.org/lpieralisi/pci/c/7698c0f155

Thanks,
Lorenzo