2023-11-23 08:03:00

by Jai Luthra

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: ti: k3-psil-am62: Fix SPI PDMA data

Hi Ronald,

Thanks for the patch.

On Oct 30, 2023 at 20:01:13 +0100, Ronald Wahl wrote:
> AM62x has 3 SPI channels where each channel has 4 TX and 4 RX threads.
> This also fixes the thread numbers.
>

Please add the Fixes tag so this gets backported to stable
Fixes: 5ac6bfb58777 ("dmaengine: ti: k3-psil: Add AM62x PSIL and PDMA data")

With that change,

Reviewed-by: Jai Luthra <[email protected]>

> Signed-off-by: Ronald Wahl <[email protected]>
> ---
> drivers/dma/ti/k3-psil-am62.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-psil-am62.c b/drivers/dma/ti/k3-psil-am62.c
> index 2b6fd6e37c61..1272b1541f61 100644
> --- a/drivers/dma/ti/k3-psil-am62.c
> +++ b/drivers/dma/ti/k3-psil-am62.c
> @@ -74,7 +74,9 @@ static struct psil_ep am62_src_ep_map[] = {
> PSIL_SAUL(0x7505, 21, 35, 8, 36, 0),
> PSIL_SAUL(0x7506, 22, 43, 8, 43, 0),
> PSIL_SAUL(0x7507, 23, 43, 8, 44, 0),
> - /* PDMA_MAIN0 - SPI0-3 */
> + /* PDMA_MAIN0 - SPI0-2 */
> + PSIL_PDMA_XY_PKT(0x4300),
> + PSIL_PDMA_XY_PKT(0x4301),
> PSIL_PDMA_XY_PKT(0x4302),
> PSIL_PDMA_XY_PKT(0x4303),
> PSIL_PDMA_XY_PKT(0x4304),
> @@ -85,8 +87,6 @@ static struct psil_ep am62_src_ep_map[] = {
> PSIL_PDMA_XY_PKT(0x4309),
> PSIL_PDMA_XY_PKT(0x430a),
> PSIL_PDMA_XY_PKT(0x430b),
> - PSIL_PDMA_XY_PKT(0x430c),
> - PSIL_PDMA_XY_PKT(0x430d),
> /* PDMA_MAIN1 - UART0-6 */
> PSIL_PDMA_XY_PKT(0x4400),
> PSIL_PDMA_XY_PKT(0x4401),
> @@ -141,7 +141,9 @@ static struct psil_ep am62_dst_ep_map[] = {
> /* SAUL */
> PSIL_SAUL(0xf500, 27, 83, 8, 83, 1),
> PSIL_SAUL(0xf501, 28, 91, 8, 91, 1),
> - /* PDMA_MAIN0 - SPI0-3 */
> + /* PDMA_MAIN0 - SPI0-2 */
> + PSIL_PDMA_XY_PKT(0xc300),
> + PSIL_PDMA_XY_PKT(0xc301),
> PSIL_PDMA_XY_PKT(0xc302),
> PSIL_PDMA_XY_PKT(0xc303),
> PSIL_PDMA_XY_PKT(0xc304),
> @@ -152,8 +154,6 @@ static struct psil_ep am62_dst_ep_map[] = {
> PSIL_PDMA_XY_PKT(0xc309),
> PSIL_PDMA_XY_PKT(0xc30a),
> PSIL_PDMA_XY_PKT(0xc30b),
> - PSIL_PDMA_XY_PKT(0xc30c),
> - PSIL_PDMA_XY_PKT(0xc30d),
> /* PDMA_MAIN1 - UART0-6 */
> PSIL_PDMA_XY_PKT(0xc400),
> PSIL_PDMA_XY_PKT(0xc401),
> --
> 2.41.0
>
>

--
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145


Attachments:
(No filename) (2.27 kB)
signature.asc (849.00 B)
Download all attachments

2023-11-23 08:47:06

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: ti: k3-psil-am62: Fix SPI PDMA data

On 23-11-23, 13:32, Jai Luthra wrote:
> Hi Ronald,
>
> Thanks for the patch.
>
> On Oct 30, 2023 at 20:01:13 +0100, Ronald Wahl wrote:
> > AM62x has 3 SPI channels where each channel has 4 TX and 4 RX threads.
> > This also fixes the thread numbers.
> >
>
> Please add the Fixes tag so this gets backported to stable
> Fixes: 5ac6bfb58777 ("dmaengine: ti: k3-psil: Add AM62x PSIL and PDMA data")

No need to add and post v2, b4 picks the Fixes tag and applies

--
~Vinod