2008-07-31 01:05:13

by Dave Airlie

[permalink] [raw]
Subject: [PATCH][stable] drm/radeon: fixup issue with radeon and PAT support.


With new userspace libpciaccess we can get a conflicting mapping
on the PCIE GART table in the video RAM. Always try and map it _wc.

Only do this on x86, some arches notably sparc aren't using iomap.h
so we don't get the ioremap_wc define there, so for stable better
safe than sorry.

stable: I've asked Linus to pull the same patch for the new drm layout
already.

Signed-off-by: Dave Airlie <[email protected]>
---
drivers/char/drm/drmP.h | 1 +
drivers/char/drm/drm_memory.c | 10 ++++++++++
drivers/char/drm/radeon_cp.c | 2 +-
3 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/drivers/char/drm/drmP.h b/drivers/char/drm/drmP.h
index 0764b66..1c1b13e 100644
--- a/drivers/char/drm/drmP.h
+++ b/drivers/char/drm/drmP.h
@@ -1089,6 +1089,7 @@ extern int drm_mm_remove_space_from_tail(struct drm_mm *mm, unsigned long size);
extern int drm_mm_add_space_to_tail(struct drm_mm *mm, unsigned long size);

extern void drm_core_ioremap(struct drm_map *map, struct drm_device *dev);
+extern void drm_core_ioremap_wc(struct drm_map *map, struct drm_device *dev);
extern void drm_core_ioremapfree(struct drm_map *map, struct drm_device *dev);

static __inline__ struct drm_map *drm_core_findmap(struct drm_device *dev,
diff --git a/drivers/char/drm/drm_memory.c b/drivers/char/drm/drm_memory.c
index 845081b..f347d26 100644
--- a/drivers/char/drm/drm_memory.c
+++ b/drivers/char/drm/drm_memory.c
@@ -167,6 +167,16 @@ void drm_core_ioremap(struct drm_map *map, struct drm_device *dev)
}
EXPORT_SYMBOL(drm_core_ioremap);

+void drm_core_ioremap_wc(struct drm_map *map, struct drm_device *dev)
+{
+#ifdef CONFIG_X86
+ map->handle = ioremap_wc(map->offset, map->size);
+#else
+ map->handle = ioremap(map->offset, map->size);
+#endif
+}
+EXPORT_SYMBOL(drm_core_ioremap_wc);
+
void drm_core_ioremapfree(struct drm_map *map, struct drm_device *dev)
{
if (!map->handle || !map->size)
diff --git a/drivers/char/drm/radeon_cp.c b/drivers/char/drm/radeon_cp.c
index e53158f..f0de81a 100644
--- a/drivers/char/drm/radeon_cp.c
+++ b/drivers/char/drm/radeon_cp.c
@@ -1154,7 +1154,7 @@ static int radeon_do_init_cp(struct drm_device * dev, drm_radeon_init_t * init)
dev_priv->gart_info.mapping.size =
dev_priv->gart_info.table_size;

- drm_core_ioremap(&dev_priv->gart_info.mapping, dev);
+ drm_core_ioremap_wc(&dev_priv->gart_info.mapping, dev);
dev_priv->gart_info.addr =
dev_priv->gart_info.mapping.handle;

--
1.5.5.1