2008-06-25 16:28:53

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] remove the dead ATARI_SCC{,_DMA} options

It seems the driver was removed back in kernel 2.3 but the options were
forgotten.

Reported-by: Robert P. J. Day <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>

---

arch/m68k/Kconfig | 24 +-----------------------
1 file changed, 1 insertion(+), 23 deletions(-)

d7a47518b54b51accc11a9cbfd503d740dbec087 diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 8012ff7..8c5e1de 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -490,28 +490,6 @@ config ATARI_MFPSER
Note for Falcon users: You also have an MFP port, it's just not
wired to the outside... But you could use the port under Linux.

-config ATARI_SCC
- tristate "Atari SCC serial support"
- depends on ATARI
- ---help---
- If you have serial ports based on a Zilog SCC chip (Modem2, Serial2,
- LAN) and like to use them under Linux, say Y. All built-in SCC's are
- supported (TT, MegaSTE, Falcon), and also the ST-ESCC. If you have
- two connectors for channel A (Serial2 and LAN), they are visible as
- two separate devices.
-
- To compile this driver as a module, choose M here.
-
-config ATARI_SCC_DMA
- bool "Atari SCC serial DMA support"
- depends on ATARI_SCC
- help
- This enables DMA support for receiving data on channel A of the SCC.
- If you have a TT you may say Y here and read
- drivers/char/atari_SCC.README. All other users should say N here,
- because only the TT has SCC-DMA, even if your machine keeps claiming
- so at boot time.
-
config ATARI_MIDI
tristate "Atari MIDI serial support"
depends on ATARI
@@ -628,7 +606,7 @@ config DN_SERIAL

config SERIAL_CONSOLE
bool "Support for serial port console"
- depends on (AMIGA || ATARI || MAC || SUN3 || SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_SCC=y || ATARI_MIDI=y || MAC_SCC=y || AMIGA_BUILTIN_SERIAL=y || GVPIOEXT=y || MULTIFACE_III_TTY=y || SERIAL=y || MVME147_SCC || SERIAL167 || MVME162_SCC || BVME6000_SCC || DN_SERIAL)
+ depends on (AMIGA || ATARI || MAC || SUN3 || SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_MIDI=y || MAC_SCC=y || AMIGA_BUILTIN_SERIAL=y || GVPIOEXT=y || MULTIFACE_III_TTY=y || SERIAL=y || MVME147_SCC || SERIAL167 || MVME162_SCC || BVME6000_SCC || DN_SERIAL)
---help---
If you say Y here, it will be possible to use a serial port as the
system console (the system console is the device which receives all


2008-06-26 06:00:52

by Michael Schmitz

[permalink] [raw]
Subject: Re: [2.6 patch] remove the dead ATARI_SCC{,_DMA} options

> It seems the driver was removed back in kernel 2.3 but the options were
> forgotten.
>
> Reported-by: Robert P. J. Day <[email protected]>
> Signed-off-by: Adrian Bunk <[email protected]>

A revived Atari SCC serial driver should be in Geert's patch queue, or in
the m68k kernel tree. The SCC_DMA option, however, is dead and can be
removed.

Cheers,

Michael

2008-06-26 07:11:30

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [2.6 patch] remove the dead ATARI_SCC{,_DMA} options

On Thu, 26 Jun 2008, Michael Schmitz wrote:
> > It seems the driver was removed back in kernel 2.3 but the options were
> > forgotten.
> >
> > Reported-by: Robert P. J. Day <[email protected]>
> > Signed-off-by: Adrian Bunk <[email protected]>
>
> A revived Atari SCC serial driver should be in Geert's patch queue, or in the

... which needs some rework before it can be submitted, I'm afraid (I can
take care of the checkpatch warnings, though ;-)

> m68k kernel tree. The SCC_DMA option, however, is dead and can be removed.

So I think it's safe to apply the whole patch, and readd
CONFIG_ATARI_SCC together with the new driver.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2008-06-26 07:19:20

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [2.6 patch] remove the dead ATARI_SCC{,_DMA} options

On Wed, 25 Jun 2008, Adrian Bunk wrote:
> It seems the driver was removed back in kernel 2.3 but the options were
> forgotten.
>
> Reported-by: Robert P. J. Day <[email protected]>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Geert Uytterhoeven <[email protected]>

(queued for 2.6.27)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2008-06-26 20:58:01

by Michael Schmitz

[permalink] [raw]
Subject: Re: [2.6 patch] remove the dead ATARI_SCC{,_DMA} options

Hi Geert,

>> A revived Atari SCC serial driver should be in Geert's patch queue, or in the
>
> ... which needs some rework before it can be submitted, I'm afraid (I can
> take care of the checkpatch warnings, though ;-)

What sort of work, apart from checkpatch cleanup?

>> m68k kernel tree. The SCC_DMA option, however, is dead and can be removed.
>
> So I think it's safe to apply the whole patch, and readd
> CONFIG_ATARI_SCC together with the new driver.

Just remember to add the option to my patch :-)

Thanks,

Michael

2008-06-29 05:49:03

by Brad Boyer

[permalink] [raw]
Subject: Re: [2.6 patch] remove the dead ATARI_SCC{,_DMA} options

On Wed, Jun 25, 2008 at 07:25:36PM +0300, Adrian Bunk wrote:
> It seems the driver was removed back in kernel 2.3 but the options were
> forgotten.

I believe the MAC_SCC option is for another driver that got removed. I
hope to eventually bring back support for the hardware by adding m68k
mac support to PMAC_ZILOG.

Brad Boyer
[email protected]