2010-11-21 13:35:18

by Robert P. J. Day

Subject: [PATCH] Change return type of obvious Boolean list fns to "bool".

It's clear that a number of basic list routines return simply a
Boolean value, so change their return type from "int" to "bool".

Signed-off-by: Robert P. J. Day <[email protected]>

---

Compile-tested with defconfig on x86_64. Not sure who should
be CCed when a patch touches something this basic. Andrew?


diff --git a/include/linux/list.h b/include/linux/list.h
index 9a5f8a7..1d6ed55 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -167,7 +167,7 @@ static inline void list_move_tail(struct list_head *list,
* @list: the entry to test
* @head: the head of the list
*/
-static inline int list_is_last(const struct list_head *list,
+static inline bool list_is_last(const struct list_head *list,
const struct list_head *head)
{
return list->next == head;
@@ -177,7 +177,7 @@ static inline int list_is_last(const struct list_head *list,
* list_empty - tests whether a list is empty
* @head: the list to test.
*/
-static inline int list_empty(const struct list_head *head)
+static inline bool list_empty(const struct list_head *head)
{
return head->next == head;
}
@@ -195,7 +195,7 @@ static inline int list_empty(const struct list_head *head)
* to the list entry is list_del_init(). Eg. it cannot be used
* if another CPU could re-list_add() it.
*/
-static inline int list_empty_careful(const struct list_head *head)
+static inline bool list_empty_careful(const struct list_head *head)
{
struct list_head *next = head->next;
return (next == head) && (next == head->prev);
@@ -219,7 +219,7 @@ static inline void list_rotate_left(struct list_head *head)
* list_is_singular - tests whether a list has just one entry.
* @head: the list to test.
*/
-static inline int list_is_singular(const struct list_head *head)
+static inline bool list_is_singular(const struct list_head *head)
{
return !list_empty(head) && (head->next == head->prev);
}


rday

--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
http://crashcourse.ca

Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================

2010-11-22 04:59:18

by Rakib Mullick

Subject: Re: [PATCH] Change return type of obvious Boolean list fns to "bool".

On Sun, Nov 21, 2010 at 7:35 PM, Robert P. J. Day <[email protected]> wrote:
>
> ?Compile-tested with defconfig on x86_64. ?Not sure who should
> be CCed when a patch touches something this basic. ?Andrew?
>
You can use scripts/get_maintainer.pl to find out who should be cc'ed.



thanks,
rakib

2010-11-23 19:18:24

by Randy Dunlap

Subject: Re: [PATCH] Change return type of obvious Boolean list fns to "bool".

On Sun, 21 Nov 2010 08:35:04 -0500 (EST) Robert P. J. Day wrote:

>
> It's clear that a number of basic list routines return simply a
> Boolean value, so change their return type from "int" to "bool".
>
> Signed-off-by: Robert P. J. Day <[email protected]>
>

Acked-by: Randy Dunlap <[email protected]>

with allmodconfig on i386 and x86_64.


> ---
>
> Compile-tested with defconfig on x86_64. Not sure who should
> be CCed when a patch touches something this basic. Andrew?
>
>
> diff --git a/include/linux/list.h b/include/linux/list.h
> index 9a5f8a7..1d6ed55 100644
> --- a/include/linux/list.h
> +++ b/include/linux/list.h
> @@ -167,7 +167,7 @@ static inline void list_move_tail(struct list_head *list,
> * @list: the entry to test
> * @head: the head of the list
> */
> -static inline int list_is_last(const struct list_head *list,
> +static inline bool list_is_last(const struct list_head *list,
> const struct list_head *head)
> {
> return list->next == head;
> @@ -177,7 +177,7 @@ static inline int list_is_last(const struct list_head *list,
> * list_empty - tests whether a list is empty
> * @head: the list to test.
> */
> -static inline int list_empty(const struct list_head *head)
> +static inline bool list_empty(const struct list_head *head)
> {
> return head->next == head;
> }
> @@ -195,7 +195,7 @@ static inline int list_empty(const struct list_head *head)
> * to the list entry is list_del_init(). Eg. it cannot be used
> * if another CPU could re-list_add() it.
> */
> -static inline int list_empty_careful(const struct list_head *head)
> +static inline bool list_empty_careful(const struct list_head *head)
> {
> struct list_head *next = head->next;
> return (next == head) && (next == head->prev);
> @@ -219,7 +219,7 @@ static inline void list_rotate_left(struct list_head *head)
> * list_is_singular - tests whether a list has just one entry.
> * @head: the list to test.
> */
> -static inline int list_is_singular(const struct list_head *head)
> +static inline bool list_is_singular(const struct list_head *head)
> {
> return !list_empty(head) && (head->next == head->prev);
> }


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***