Fix the following section mismatch warning when building omap2plus_defconfig:
WARNING: vmlinux.o(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe()
Signed-off-by: Paul Walmsley <[email protected]>
Cc: Samuel Ortiz <[email protected]>
---
drivers/mfd/twl-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 35275ba..615cf38 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -969,7 +969,7 @@ static int twl_remove(struct i2c_client *client)
}
/* NOTE: this driver only handles a single twl4030/tps659x0 chip */
-static int __init
+static int
twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
{
int status;
--
1.7.2.3
On Tue, 7 Dec 2010, Bryan Wu wrote:
> On Tue, Dec 7, 2010 at 8:35 AM, Paul Walmsley <[email protected]> wrote:
> >
> > Fix the following section mismatch warning when building omap2plus_defconfig:
> >
> > WARNING: vmlinux.o(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe()
> >
> > Signed-off-by: Paul Walmsley <[email protected]>
> > Cc: Samuel Ortiz <[email protected]>
> > ---
> > ?drivers/mfd/twl-core.c | ? ?2 +-
> > ?1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> > index 35275ba..615cf38 100644
> > --- a/drivers/mfd/twl-core.c
> > +++ b/drivers/mfd/twl-core.c
> > @@ -969,7 +969,7 @@ static int twl_remove(struct i2c_client *client)
> > ?}
> >
> > ?/* NOTE: ?this driver only handles a single twl4030/tps659x0 chip */
> > -static int __init
> > +static int
>
> I think we might change __init to __devinit.
>
> > ?twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
> > ?{
> > ? ? ? ?int ? ? ? ? ? ? ? ? ? ? ? ? ? ? status;
> > --
That's fine with me. Samuel et al, Bryan's already done a patch
for this stuff:
https://patchwork.kernel.org/patch/367011/
so we should use that instead, if you're happy with it. Samuel, maybe we
could get an ack from you on it?
- Paul
On Tue, Dec 7, 2010 at 8:35 AM, Paul Walmsley <[email protected]> wrote:
>
> Fix the following section mismatch warning when building omap2plus_defconfig:
>
> WARNING: vmlinux.o(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe()
>
> Signed-off-by: Paul Walmsley <[email protected]>
> Cc: Samuel Ortiz <[email protected]>
> ---
> ?drivers/mfd/twl-core.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> index 35275ba..615cf38 100644
> --- a/drivers/mfd/twl-core.c
> +++ b/drivers/mfd/twl-core.c
> @@ -969,7 +969,7 @@ static int twl_remove(struct i2c_client *client)
> ?}
>
> ?/* NOTE: ?this driver only handles a single twl4030/tps659x0 chip */
> -static int __init
> +static int
I think we might change __init to __devinit.
> ?twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
> ?{
> ? ? ? ?int ? ? ? ? ? ? ? ? ? ? ? ? ? ? status;
> --
Thanks,
--
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?http://www.canonical.com
Ubuntu - Linux for human beings | http://www.ubuntu.com
Hi Paul,
On Mon, Dec 06, 2010 at 06:40:38PM -0700, Paul Walmsley wrote:
> On Tue, 7 Dec 2010, Bryan Wu wrote:
>
> > On Tue, Dec 7, 2010 at 8:35 AM, Paul Walmsley <[email protected]> wrote:
> > >
> > > Fix the following section mismatch warning when building omap2plus_defconfig:
> > >
> > > WARNING: vmlinux.o(.data+0x47d7c): Section mismatch in reference from the variable twl_driver to the function .init.text:twl_probe()
> > >
> > > Signed-off-by: Paul Walmsley <[email protected]>
> > > Cc: Samuel Ortiz <[email protected]>
> > > ---
> > > ?drivers/mfd/twl-core.c | ? ?2 +-
> > > ?1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> > > index 35275ba..615cf38 100644
> > > --- a/drivers/mfd/twl-core.c
> > > +++ b/drivers/mfd/twl-core.c
> > > @@ -969,7 +969,7 @@ static int twl_remove(struct i2c_client *client)
> > > ?}
> > >
> > > ?/* NOTE: ?this driver only handles a single twl4030/tps659x0 chip */
> > > -static int __init
> > > +static int
> >
> > I think we might change __init to __devinit.
> >
> > > ?twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
> > > ?{
> > > ? ? ? ?int ? ? ? ? ? ? ? ? ? ? ? ? ? ? status;
> > > --
>
> That's fine with me. Samuel et al, Bryan's already done a patch
> for this stuff:
>
> https://patchwork.kernel.org/patch/367011/
>
> so we should use that instead, if you're happy with it. Samuel, maybe we
> could get an ack from you on it?
The twl driver is not OMAP specific, so this should be a separate patch thatI
will merge to my mfd tree.
If you really insist in pushing this through Tony's tree, then please add my
Acked-by for the mfd part.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
Hello Samuel,
On Tue, 7 Dec 2010, Samuel Ortiz wrote:
> On Mon, Dec 06, 2010 at 06:40:38PM -0700, Paul Walmsley wrote:
> >
> > That's fine with me. Samuel et al, Bryan's already done a patch
> > for this stuff:
> >
> > https://patchwork.kernel.org/patch/367011/
> >
> > so we should use that instead, if you're happy with it. Samuel, maybe we
> > could get an ack from you on it?
> The twl driver is not OMAP specific, so this should be a separate patch thatI
> will merge to my mfd tree.
> If you really insist in pushing this through Tony's tree, then please add my
> Acked-by for the mfd part.
I don't insist at all :-)
Bryan, maybe split your patch into a mach-omap2 patch and a TWL
driver-specific patch, and send the latter for Samuel?
- Paul
On Wed, Dec 8, 2010 at 12:12 AM, Paul Walmsley <[email protected]> wrote:
> Hello Samuel,
>
> On Tue, 7 Dec 2010, Samuel Ortiz wrote:
>
>> On Mon, Dec 06, 2010 at 06:40:38PM -0700, Paul Walmsley wrote:
>> >
>> > That's fine with me. ?Samuel et al, Bryan's already done a patch
>> > for this stuff:
>> >
>> > https://patchwork.kernel.org/patch/367011/
>> >
>> > so we should use that instead, if you're happy with it. ?Samuel, maybe we
>> > could get an ack from you on it?
>> The twl driver is not OMAP specific, so this should be a separate patch thatI
>> will merge to my mfd tree.
>> If you really insist in pushing this through Tony's tree, then please add my
>> Acked-by for the mfd part.
>
> I don't insist at all :-)
>
> Bryan, maybe split your patch into a mach-omap2 patch and a TWL
> driver-specific patch, and send the latter for Samuel?
>
>
No problem. I'll do soon.
Thanks,
--
Bryan Wu <[email protected]>
Kernel Developer ? ?+86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd. ? ? ?http://www.canonical.com
Ubuntu - Linux for human beings | http://www.ubuntu.com