2011-06-09 18:22:00

by Daniel Kiper

Subject: [PATCH] mm: Simplify code by SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro usage

git commit a539f3533b78e39a22723d6d3e1e11b6c14454d9 (mm: add SECTION_ALIGN_UP()
and SECTION_ALIGN_DOWN() macro) introduced SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN()
macro. Use those macros to increase code readability.

This patch applies to Linus' git tree, v3.0-rc2 tag.

Signed-off-by: Daniel Kiper <[email protected]>
---
mm/page_cgroup.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
index 74ccff6..d818525 100644
--- a/mm/page_cgroup.c
+++ b/mm/page_cgroup.c
@@ -222,8 +222,8 @@ int __meminit online_page_cgroup(unsigned long start_pfn,
unsigned long start, end, pfn;
int fail = 0;

- start = start_pfn & ~(PAGES_PER_SECTION - 1);
- end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);
+ start = SECTION_ALIGN_DOWN(start_pfn);
+ end = SECTION_ALIGN_UP(start_pfn + nr_pages);

for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) {
if (!pfn_present(pfn))
@@ -245,8 +245,8 @@ int __meminit offline_page_cgroup(unsigned long start_pfn,
{
unsigned long start, end, pfn;

- start = start_pfn & ~(PAGES_PER_SECTION - 1);
- end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);
+ start = SECTION_ALIGN_DOWN(start_pfn);
+ end = SECTION_ALIGN_UP(start_pfn + nr_pages);

for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION)
__free_page_cgroup(pfn);
--
1.5.6.5

2011-06-09 19:54:13

by David Rientjes

Subject: Re: [PATCH] mm: Simplify code by SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro usage

On Thu, 9 Jun 2011, Daniel Kiper wrote:

> git commit a539f3533b78e39a22723d6d3e1e11b6c14454d9 (mm: add SECTION_ALIGN_UP()
> and SECTION_ALIGN_DOWN() macro) introduced SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN()
> macro. Use those macros to increase code readability.
>
> This patch applies to Linus' git tree, v3.0-rc2 tag.
>

[ This patch would go through the -mm tree so it should always be based
on the latest git tree, no need to mention it. Alternatively, if it
was based on something in -mm that isn't in the latest git yet, then
you only need to append the "-mm" tag to the subject line:
"[patch -mm]". ]

> Signed-off-by: Daniel Kiper <[email protected]>

Acked-by: David Rientjes <[email protected]>