2012-05-24 21:22:31

by David Rientjes

Subject: Re: [PATCH -V6 03/14] hugetlbfs: Add an inline helper for finding hstate index

On Mon, 16 Apr 2012, Aneesh Kumar K.V wrote:

> From: "Aneesh Kumar K.V" <[email protected]>
>
> Add an inline helper and use it in the code.
>
> Acked-by: Michal Hocko <[email protected]>
> Reviewed-by: KAMEZAWA Hiroyuki <[email protected]>
> Signed-off-by: Aneesh Kumar K.V <[email protected]>

I like the helper function, but you missed using it in
hugetlb_init().

2012-05-27 20:08:34

by Aneesh Kumar K.V

Subject: Re: [PATCH -V6 03/14] hugetlbfs: Add an inline helper for finding hstate index

On Thu, May 24, 2012 at 02:22:27PM -0700, David Rientjes wrote:
> On Mon, 16 Apr 2012, Aneesh Kumar K.V wrote:
>
> > From: "Aneesh Kumar K.V" <[email protected]>
> >
> > Add an inline helper and use it in the code.
> >
> > Acked-by: Michal Hocko <[email protected]>
> > Reviewed-by: KAMEZAWA Hiroyuki <[email protected]>
> > Signed-off-by: Aneesh Kumar K.V <[email protected]>
>
> I like the helper function, but you missed using it in
> hugetlb_init().
>

Will do this as an add on patc on top

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 4b90dd5..58eead5 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1891,7 +1891,7 @@ static int __init hugetlb_init(void)
if (!size_to_hstate(default_hstate_size))
hugetlb_add_hstate(HUGETLB_PAGE_ORDER);
}
- default_hstate_idx = size_to_hstate(default_hstate_size) - hstates;
+ default_hstate_idx = hstate_index(size_to_hstate(default_hstate_size));
if (default_hstate_max_huge_pages)
default_hstate.max_huge_pages = default_hstate_max_huge_pages;