2015-06-23 01:53:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the drm-exynos tree

Hi Inki,

After merging the drm-exynos tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here

Caused by commit:

a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")

I have used the drm-exynos from next-20150622 for today.

--
Cheers,
Stephen Rothwell [email protected]

Attachments:
(No filename) (819.00 B)
OpenPGP digital signature
Subject: Re: linux-next: build failure after merge of the drm-exynos tree

Hi Stephen,

On 2015년 06월 23일 10:52, Stephen Rothwell wrote:
> Hi Inki,
>
> After merging the drm-exynos tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Thanks for report.

I found out this problem. That is because below patch missed "static"
when defining of_graph_get_endpoint_by_regs function,
a0f7001c18ca ("of: add helper for getting endpoint node of specific
identifiers")

For this, I will fix and post it soon.

Thanks,
Inki Dae

>
> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>
> Caused by commit:
>
> a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
>
> I have used the drm-exynos from next-20150622 for today.
>

2015-06-24 01:01:38

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the drm-exynos tree

Hi Dave,

On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the drm-exynos tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>
> Caused by commit:
>
> a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")

This failure is now in the drm tree (where above patch is commit
8ccd0d0ca041). I have used the patch from Inki for today.

--
Cheers,
Stephen Rothwell [email protected]

Attachments:
(No filename) (819.00 B)
OpenPGP digital signature
Subject: Re: linux-next: build failure after merge of the drm-exynos tree

Hi Dave and Stephen,

On 2015년 06월 24일 10:01, Stephen Rothwell wrote:
> Hi Dave,
>
> On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <[email protected]> wrote:
>>
>> After merging the drm-exynos tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
>> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
>> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
>> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
>> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
>> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>>
>> Caused by commit:
>>
>> a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
>
> This failure is now in the drm tree (where above patch is commit
> 8ccd0d0ca041). I have used the patch from Inki for today.

As you know, I posted below patch which fixes the build error,
[PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function

However, I think we need Acked-by from device tree maintainer to merge
it to drm-next.

Thanks,
Inki Dae

>

2015-06-24 01:25:20

by Dave Airlie

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the drm-exynos tree


> > Hi Dave,
> >
> > On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <[email protected]> wrote:
> >>
> >> After merging the drm-exynos tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
> >> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
> >> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
> >> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
> >> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
> >> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> >> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
> >> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
> >> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
> >>
> >> Caused by commit:
> >>
> >> a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
> >
> > This failure is now in the drm tree (where above patch is commit
> > 8ccd0d0ca041). I have used the patch from Inki for today.
>
> As you know, I posted below patch which fixes the build error,
> [PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function
>
> However, I think we need Acked-by from device tree maintainer to merge
> it to drm-next.
>

In times like this I usually go with forgivness rather than permission,
also previous Ack's are good enough for me to cover build problems.

I've pushed the fix to drm-next.

Dave.

Subject: Re: linux-next: build failure after merge of the drm-exynos tree

On 2015년 06월 24일 10:21, Inki Dae wrote:
> Hi Dave and Stephen,
>
> On 2015년 06월 24일 10:01, Stephen Rothwell wrote:
>> Hi Dave,
>>
>> On Tue, 23 Jun 2015 11:52:45 +1000 Stephen Rothwell <[email protected]> wrote:
>>>
>>> After merging the drm-exynos tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> drivers/media/i2c/adv7604.o: In function `of_graph_get_endpoint_by_regs':
>>> adv7604.c:(.text+0x586c): multiple definition of `of_graph_get_endpoint_by_regs'
>>> drivers/media/i2c/adv7343.o:adv7343.c:(.text+0xa13): first defined here
>>> drivers/media/platform/soc_camera/atmel-isi.o: In function `of_graph_get_endpoint_by_regs':
>>> atmel-isi.c:(.text+0x1ec9): multiple definition of `of_graph_get_endpoint_by_regs'
>>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>>> drivers/media/platform/soc_camera/rcar_vin.o: In function `of_graph_get_endpoint_by_regs':
>>> rcar_vin.c:(.text+0x307c): multiple definition of `of_graph_get_endpoint_by_regs'
>>> drivers/media/platform/soc_camera/soc_camera.o:soc_camera.c:(.text+0x2ce3): first defined here
>>>
>>> Caused by commit:
>>>
>>> a0f7001c18ca ("of: add helper for getting endpoint node of specific identifiers")
>>
>> This failure is now in the drm tree (where above patch is commit
>> 8ccd0d0ca041). I have used the patch from Inki for today.
>
> As you know, I posted below patch which fixes the build error,
> [PATCH] of: fix a build error to f_graph_get_endpoint_by_regs function
>
> However, I think we need Acked-by from device tree maintainer to merge
> it to drm-next.

Sorry, Rob did already Acked-by. :)

Thanks,
Inki Dae

>
> Thanks,
> Inki Dae
>
>>
>