Expand the fs/Kconfig "help" info to clarify why it's a bad idea to
deselect the TMPFS_POSIX_ACL config variable.
Signed-off-by: Robert P. J. Day <[email protected]>
---
diff --git a/fs/Kconfig b/fs/Kconfig
index 19891aa..4217543 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -127,14 +127,20 @@ config TMPFS_POSIX_ACL
select TMPFS_XATTR
select GENERIC_ACL
help
- POSIX Access Control Lists (ACLs) support permissions for users and
- groups beyond the owner/group/world scheme.
+ POSIX Access Control Lists (ACLs) support additional access rights
+ for users and groups beyond the standard owner/group/world scheme,
+ and this option selects support for ACLs specifically for tmpfs
+ filesystems.
+
+ If you've selected TMPFS, you almost certainly want this option
+ as well since a number of user space features (ie., ALSA sound)
+ require POSIX ACL support under /dev to work properly. In other
+ words, if you're not sure and you have no *compelling* reason to
+ deselect this feature, say Y.
To learn more about Access Control Lists, visit the POSIX ACLs for
Linux website <http://acl.bestbits.at/>.
- If you don't know what Access Control Lists are, say N.
-
config TMPFS_XATTR
bool "Tmpfs extended attributes"
depends on TMPFS
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
On Sat, 18 Jun 2011 07:45:35 -0400 (EDT) Robert P. J. Day wrote:
>
> Expand the fs/Kconfig "help" info to clarify why it's a bad idea to
> deselect the TMPFS_POSIX_ACL config variable.
>
> Signed-off-by: Robert P. J. Day <[email protected]>
>
> ---
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 19891aa..4217543 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -127,14 +127,20 @@ config TMPFS_POSIX_ACL
> select TMPFS_XATTR
> select GENERIC_ACL
> help
> - POSIX Access Control Lists (ACLs) support permissions for users and
> - groups beyond the owner/group/world scheme.
> + POSIX Access Control Lists (ACLs) support additional access rights
> + for users and groups beyond the standard owner/group/world scheme,
> + and this option selects support for ACLs specifically for tmpfs
> + filesystems.
> +
> + If you've selected TMPFS, you almost certainly want this option
> + as well since a number of user space features (ie., ALSA sound)
e.g.,
?
Otherwise, looks good to me.
Thanks.
> + require POSIX ACL support under /dev to work properly. In other
> + words, if you're not sure and you have no *compelling* reason to
> + deselect this feature, say Y.
>
> To learn more about Access Control Lists, visit the POSIX ACLs for
> Linux website <http://acl.bestbits.at/>.
>
> - If you don't know what Access Control Lists are, say N.
> -
> config TMPFS_XATTR
> bool "Tmpfs extended attributes"
> depends on TMPFS
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Sat, 18 Jun 2011, Randy Dunlap wrote:
> On Sat, 18 Jun 2011 07:45:35 -0400 (EDT) Robert P. J. Day wrote:
>
> >
> > Expand the fs/Kconfig "help" info to clarify why it's a bad idea to
> > deselect the TMPFS_POSIX_ACL config variable.
> >
> > Signed-off-by: Robert P. J. Day <[email protected]>
> >
> > ---
> >
> > diff --git a/fs/Kconfig b/fs/Kconfig
> > index 19891aa..4217543 100644
> > --- a/fs/Kconfig
> > +++ b/fs/Kconfig
> > @@ -127,14 +127,20 @@ config TMPFS_POSIX_ACL
> > select TMPFS_XATTR
> > select GENERIC_ACL
> > help
> > - POSIX Access Control Lists (ACLs) support permissions for users and
> > - groups beyond the owner/group/world scheme.
> > + POSIX Access Control Lists (ACLs) support additional access rights
> > + for users and groups beyond the standard owner/group/world scheme,
> > + and this option selects support for ACLs specifically for tmpfs
> > + filesystems.
> > +
> > + If you've selected TMPFS, you almost certainly want this option
> > + as well since a number of user space features (ie., ALSA sound)
>
> e.g.,
> ?
>
> Otherwise, looks good to me.
> Thanks.
oops, i can submit a V2 patch that changes that. or you can hack
what i submitted. either way works for me.
rday
On Sat, 18 Jun 2011 11:03:35 -0400 (EDT) Robert P. J. Day wrote:
> On Sat, 18 Jun 2011, Randy Dunlap wrote:
>
> > On Sat, 18 Jun 2011 07:45:35 -0400 (EDT) Robert P. J. Day wrote:
> >
> > >
> > > Expand the fs/Kconfig "help" info to clarify why it's a bad idea to
> > > deselect the TMPFS_POSIX_ACL config variable.
> > >
> > > Signed-off-by: Robert P. J. Day <[email protected]>
> > >
> > > ---
> > >
> > > diff --git a/fs/Kconfig b/fs/Kconfig
> > > index 19891aa..4217543 100644
> > > --- a/fs/Kconfig
> > > +++ b/fs/Kconfig
> > > @@ -127,14 +127,20 @@ config TMPFS_POSIX_ACL
> > > select TMPFS_XATTR
> > > select GENERIC_ACL
> > > help
> > > - POSIX Access Control Lists (ACLs) support permissions for users and
> > > - groups beyond the owner/group/world scheme.
> > > + POSIX Access Control Lists (ACLs) support additional access rights
> > > + for users and groups beyond the standard owner/group/world scheme,
> > > + and this option selects support for ACLs specifically for tmpfs
> > > + filesystems.
> > > +
> > > + If you've selected TMPFS, you almost certainly want this option
> > > + as well since a number of user space features (ie., ALSA sound)
> >
> > e.g.,
> > ?
> >
> > Otherwise, looks good to me.
> > Thanks.
>
> oops, i can submit a V2 patch that changes that. or you can hack
> what i submitted. either way works for me.
Please submit a v2 patch and cc: akpm on it since he will probably merge it.
thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Jun 18 Robert P. J. Day wrote:
> + If you've selected TMPFS, you almost certainly want this option
> + as well since a number of user space features (ie., ALSA sound)
> + require POSIX ACL support under /dev to work properly. In other
There are still many systems which do not use ACLs in /dev or anywhere
else at all. Hence, "may require POSIX ACL support".
> + words, if you're not sure and you have no *compelling* reason to
> + deselect this feature, say Y.
The asterisks around compelling are unnecessary.
BTW, thanks for improving the Kconfig help texts.
--
Stefan Richter
-=====-==-== -==- =--=-
http://arcgraph.de/sr/
On Sat, 18 Jun 2011, Stefan Richter wrote:
> On Jun 18 Robert P. J. Day wrote:
> > + If you've selected TMPFS, you almost certainly want this option
> > + as well since a number of user space features (ie., ALSA sound)
> > + require POSIX ACL support under /dev to work properly. In other
>
> There are still many systems which do not use ACLs in /dev or anywhere
> else at all. Hence, "may require POSIX ACL support".
>
> > + words, if you're not sure and you have no *compelling* reason to
> > + deselect this feature, say Y.
>
> The asterisks around compelling are unnecessary.
ok, i can reword and resubmit if you like.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
On Sat, 18 Jun 2011 13:32:14 -0400 (EDT) Robert P. J. Day wrote:
> On Sat, 18 Jun 2011, Stefan Richter wrote:
>
> > On Jun 18 Robert P. J. Day wrote:
> > > + If you've selected TMPFS, you almost certainly want this option
> > > + as well since a number of user space features (ie., ALSA sound)
> > > + require POSIX ACL support under /dev to work properly. In other
> >
> > There are still many systems which do not use ACLs in /dev or anywhere
> > else at all. Hence, "may require POSIX ACL support".
> >
> > > + words, if you're not sure and you have no *compelling* reason to
> > > + deselect this feature, say Y.
> >
> > The asterisks around compelling are unnecessary.
agreed.
> ok, i can reword and resubmit if you like.
yes, please.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***