2013-10-07 21:46:09

by Rob Herring

Subject: [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain

From: Rob Herring <[email protected]>

xen-tpmfront fails to build on arm64 with the following error:

drivers/char/tpm/xen-tpmfront.c: In function ‘xen_tpmfront_init’:
drivers/char/tpm/xen-tpmfront.c:422:2: error: implicit declaration of function ‘xen_domain’ [-Werror=implicit-function-declaration]

Add include of xen/xen.h to fix this.

Signed-off-by: Rob Herring <[email protected]>
Cc: Leonidas Da Silva Barbosa <[email protected]>
Cc: Ashley Lai <[email protected]>
Cc: Rajiv Andrade <[email protected]>
Cc: Marcel Selhorst <[email protected]>
Cc: Sirrix AG <[email protected]>
Cc: [email protected]
---
drivers/char/tpm/xen-tpmfront.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 06189e5..94c280d 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -10,6 +10,7 @@
#include <linux/errno.h>
#include <linux/err.h>
#include <linux/interrupt.h>
+#include <xen/xen.h>
#include <xen/events.h>
#include <xen/interface/io/tpmif.h>
#include <xen/grant_table.h>
--
1.8.1.2

2013-10-08 14:31:40

by Stefano Stabellini

Subject: Re: [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain

On Mon, 7 Oct 2013, Rob Herring wrote:
> From: Rob Herring <[email protected]>
>
> xen-tpmfront fails to build on arm64 with the following error:
>
> drivers/char/tpm/xen-tpmfront.c: In function ‘xen_tpmfront_init’:
> drivers/char/tpm/xen-tpmfront.c:422:2: error: implicit declaration of function ‘xen_domain’ [-Werror=implicit-function-declaration]
>
> Add include of xen/xen.h to fix this.
>
> Signed-off-by: Rob Herring <[email protected]>
> Cc: Leonidas Da Silva Barbosa <[email protected]>
> Cc: Ashley Lai <[email protected]>
> Cc: Rajiv Andrade <[email protected]>
> Cc: Marcel Selhorst <[email protected]>
> Cc: Sirrix AG <[email protected]>
> Cc: [email protected]

Thanks, added to my queue


> drivers/char/tpm/xen-tpmfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 06189e5..94c280d 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -10,6 +10,7 @@
> #include <linux/errno.h>
> #include <linux/err.h>
> #include <linux/interrupt.h>
> +#include <xen/xen.h>
> #include <xen/events.h>
> #include <xen/interface/io/tpmif.h>
> #include <xen/grant_table.h>
> --
> 1.8.1.2
>

2013-10-08 15:14:22

by Ashley Lai

Subject: Re: [tpmdd-devel] [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain

On Mon, 2013-10-07 at 16:45 -0500, Rob Herring wrote:
> From: Rob Herring <[email protected]>
>
> xen-tpmfront fails to build on arm64 with the following error:
>

Reviewed-by: Ashley Lai <[email protected]>
Acked-by: Ashley Lai <[email protected]>

Thanks,
--Ashley Lai