2014-06-07 11:30:47

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 1/1] mm/slab.c: add __init to init_lock_keys

init_lock_keys is only called by __init kmem_cache_init_late

Cc: Christoph Lameter <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
mm/slab.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 19d9218..4ff5298 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -536,7 +536,7 @@ static inline void on_slab_lock_classes(struct kmem_cache *cachep)
on_slab_lock_classes_node(cachep, node);
}

-static inline void init_lock_keys(void)
+static inline void __init init_lock_keys(void)
{
int node;

@@ -544,7 +544,7 @@ static inline void init_lock_keys(void)
init_node_lock_keys(node);
}
#else
-static void init_node_lock_keys(int q)
+static void __init init_node_lock_keys(int q)
{
}

--
1.9.1


Subject: Re: [PATCH 1/1] mm/slab.c: add __init to init_lock_keys

On Sat, 7 Jun 2014, Fabian Frederick wrote:

> init_lock_keys is only called by __init kmem_cache_init_late

Acked-by: Christoph Lameter <[email protected]>

2014-06-07 21:56:57

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH 1/1] mm/slab.c: add __init to init_lock_keys

On Sat, 7 Jun 2014, Fabian Frederick wrote:

> init_lock_keys is only called by __init kmem_cache_init_late
>
> Cc: Christoph Lameter <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>

No functional change because these functions are inlined, but it makes
sense anyway.

Acked-by: David Rientjes <[email protected]>