2014-10-28 17:18:31

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: bugon.cocci: fix Options at the macro

The comma after --no-includes makes coccinelle to not run the script:

/usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
Options are:
--sp-file <file> the semantic patch file
-o <file> the output file
--in-place do the modification on the file directly
--backup-suffix suffix to use when making a backup for inplace
...

At least with Fedora 20 coccinelle package:
coccinelle-1.0.0-0.rc20.1.fc21.x86_64

Signed-off-by: Mauro Carvalho Chehab <[email protected]>

diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci
index 556456ca761c..3b7eec24fb5a 100644
--- a/scripts/coccinelle/misc/bugon.cocci
+++ b/scripts/coccinelle/misc/bugon.cocci
@@ -8,7 +8,7 @@
// Confidence: High
// Copyright: (C) 2014 Himangi Saraogi. GPLv2.
// Comments:
-// Options: --no-includes, --include-headers
+// Options: --no-includes --include-headers

virtual patch
virtual context


2014-10-28 18:29:59

by Julia Lawall

[permalink] [raw]
Subject: Re: bugon.cocci: fix Options at the macro

Acked-by: Julia Lawall <[email protected]>

Thanks!
julia

On Tue, 28 Oct 2014, Mauro Carvalho Chehab wrote:

> The comma after --no-includes makes coccinelle to not run the script:
>
> /usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
> Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
> Options are:
> --sp-file <file> the semantic patch file
> -o <file> the output file
> --in-place do the modification on the file directly
> --backup-suffix suffix to use when making a backup for inplace
> ...
>
> At least with Fedora 20 coccinelle package:
> coccinelle-1.0.0-0.rc20.1.fc21.x86_64
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci
> index 556456ca761c..3b7eec24fb5a 100644
> --- a/scripts/coccinelle/misc/bugon.cocci
> +++ b/scripts/coccinelle/misc/bugon.cocci
> @@ -8,7 +8,7 @@
> // Confidence: High
> // Copyright: (C) 2014 Himangi Saraogi. GPLv2.
> // Comments:
> -// Options: --no-includes, --include-headers
> +// Options: --no-includes --include-headers
>
> virtual patch
> virtual context
>

2014-11-07 17:50:04

by Wolfram Sang

[permalink] [raw]
Subject: Re: [Cocci] bugon.cocci: fix Options at the macro

On Tue, Oct 28, 2014 at 03:18:24PM -0200, Mauro Carvalho Chehab wrote:
> The comma after --no-includes makes coccinelle to not run the script:
>
> /usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
> Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
> Options are:
> --sp-file <file> the semantic patch file
> -o <file> the output file
> --in-place do the modification on the file directly
> --backup-suffix suffix to use when making a backup for inplace
> ...
>
> At least with Fedora 20 coccinelle package:
> coccinelle-1.0.0-0.rc20.1.fc21.x86_64
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Yay, with this my patch handling scripts finally work again as they used
to! Please let it go into 3.18.

Tested-by: Wolfram Sang <[email protected]>

Attachments:
(No filename) (1.19 kB)
 signature.asc (819.00 B)
Digital signature Download all attachments

2014-11-21 18:06:30

by Wolfram Sang

[permalink] [raw]
Subject: Re: [Cocci] bugon.cocci: fix Options at the macro

On Fri, Nov 07, 2014 at 06:51:05PM +0100, Wolfram Sang wrote:
> On Tue, Oct 28, 2014 at 03:18:24PM -0200, Mauro Carvalho Chehab wrote:
> > The comma after --no-includes makes coccinelle to not run the script:
> >
> > /usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
> > Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
> > Options are:
> > --sp-file <file> the semantic patch file
> > -o <file> the output file
> > --in-place do the modification on the file directly
> > --backup-suffix suffix to use when making a backup for inplace
> > ...
> >
> > At least with Fedora 20 coccinelle package:
> > coccinelle-1.0.0-0.rc20.1.fc21.x86_64
> >
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> Yay, with this my patch handling scripts finally work again as they used
> to! Please let it go into 3.18.
>
> Tested-by: Wolfram Sang <[email protected]>

Ping.

Attachments:
(No filename) (1.30 kB)
 signature.asc (819.00 B)
Digital signature Download all attachments

2014-11-24 21:03:58

by Michal Marek

[permalink] [raw]
Subject: Re: [Cocci] bugon.cocci: fix Options at the macro

Dne 21.11.2014 v 19:07 Wolfram Sang napsal(a):
> On Fri, Nov 07, 2014 at 06:51:05PM +0100, Wolfram Sang wrote:
>> On Tue, Oct 28, 2014 at 03:18:24PM -0200, Mauro Carvalho Chehab wrote:
>>> The comma after --no-includes makes coccinelle to not run the script:
>>>
>>> /usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
>>> Usage: spatch.opt --sp-file <SP> <infile> [-o <outfile>] [--iso-file <iso>] [options]
>>> Options are:
>>> --sp-file <file> the semantic patch file
>>> -o <file> the output file
>>> --in-place do the modification on the file directly
>>> --backup-suffix suffix to use when making a backup for inplace
>>> ...
>>>
>>> At least with Fedora 20 coccinelle package:
>>> coccinelle-1.0.0-0.rc20.1.fc21.x86_64
>>>
>>> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>>
>> Yay, with this my patch handling scripts finally work again as they used
>> to! Please let it go into 3.18.
>>
>> Tested-by: Wolfram Sang <[email protected]>
>
> Ping.

Sorry for the delay. Applied now to kbuild.git#misc.

Michal