2015-07-20 15:29:18

by Konstantin Khlebnikov

[permalink] [raw]
Subject: [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set

This patch fixes creation of new kmem-caches after enabling sanity_checks
for existing mergeable kmem-caches in runtime: before that patch creation
fails because unique name in sysfs already taken by existing kmem-cache.

Unlike to other debug options this doesn't change object layout and could
be enabled and disabled at any time.

Signed-off-by: Konstantin Khlebnikov <[email protected]>
---
mm/slab_common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 3e5f8f29c286..86831105a09f 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -37,8 +37,7 @@ struct kmem_cache *kmem_cache;
SLAB_TRACE | SLAB_DESTROY_BY_RCU | SLAB_NOLEAKTRACE | \
SLAB_FAILSLAB)

-#define SLAB_MERGE_SAME (SLAB_DEBUG_FREE | SLAB_RECLAIM_ACCOUNT | \
- SLAB_CACHE_DMA | SLAB_NOTRACK)
+#define SLAB_MERGE_SAME (SLAB_RECLAIM_ACCOUNT | SLAB_CACHE_DMA | SLAB_NOTRACK)

/*
* Merge control. If this is set then no merging of slab caches will occur.


Subject: Re: [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set

On Mon, 20 Jul 2015, Konstantin Khlebnikov wrote:

> This patch fixes creation of new kmem-caches after enabling sanity_checks
> for existing mergeable kmem-caches in runtime: before that patch creation
> fails because unique name in sysfs already taken by existing kmem-cache.
>
> Unlike to other debug options this doesn't change object layout and could
> be enabled and disabled at any time.

Acked-by: Christoph Lameter <[email protected]>

2015-07-21 22:31:17

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH v2] mm/slub: allow merging when SLAB_DEBUG_FREE is set

On Mon, 20 Jul 2015, Konstantin Khlebnikov wrote:

> This patch fixes creation of new kmem-caches after enabling sanity_checks
> for existing mergeable kmem-caches in runtime: before that patch creation
> fails because unique name in sysfs already taken by existing kmem-cache.
>
> Unlike to other debug options this doesn't change object layout and could
> be enabled and disabled at any time.
>
> Signed-off-by: Konstantin Khlebnikov <[email protected]>

Acked-by: David Rientjes <[email protected]>