2015-07-28 07:17:10

by Shraddha Barke

Subject: [PATCH] Drivers: isdn: Drop unnecessary continue

The semantic patch used to make this change is :

@@
@@
for (...;...;...) {
...
if (...) {
...
- continue;
}
}

Signed-off-by: Shraddha Barke <[email protected]>
---
drivers/isdn/hardware/mISDN/hfcsusb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index 114f3bc..34e4b6c 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -1923,7 +1923,6 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
(le16_to_cpu(dev->descriptor.idProduct)
== hfcsusb_idtab[i].idProduct)) {
vend_idx = i;
- continue;
}
}

--
2.1.0

2015-07-28 07:28:35

by Julia Lawall

Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue

On Tue, 28 Jul 2015, Shraddha Barke wrote:

> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
> ...
> if (...) {
> ...
> - continue;
> }
> }
>
> Signed-off-by: Shraddha Barke <[email protected]>
> ---
> drivers/isdn/hardware/mISDN/hfcsusb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..34e4b6c 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1923,7 +1923,6 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
> (le16_to_cpu(dev->descriptor.idProduct)
> == hfcsusb_idtab[i].idProduct)) {
> vend_idx = i;
> - continue;

Now there is only one statement in the branch, so the {} should go as
well.

julia

> }
> }
>
> --
> 2.1.0
>
>