2017-11-28 21:50:20

by Shrikrishna Khare

[permalink] [raw]
Subject: Re: [PATCH net-next] vmxnet3: increase default rx ring sizes



On Tue, 28 Nov 2017, Andrew Lunn wrote:

> > /*
> > * Version numbers
> > */
> > -#define VMXNET3_DRIVER_VERSION_STRING "1.4.a.0-k"
> > +#define VMXNET3_DRIVER_VERSION_STRING "1.4.11.0-k"
> >
> > /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
> > -#define VMXNET3_DRIVER_VERSION_NUM 0x01040a00
> > +#define VMXNET3_DRIVER_VERSION_NUM 0x01040b00
>
> Version strings in drivers are totally pointless, but should not this
> be 0x01041100?
>

Version number is hex value written to vmxnet3 emulation, thus 0x1040b00
is correct (0x0b = 11). The VERSION_STRING should have previously been
"1.4.10.0-k", this patch rectifies that by setting correct value
"1.4.11.0-k".

I will let John Savanyo (cc'ed) comment on having the version in the
driver part.

Thanks,
Shri

From 1585347228008690667@xxx Tue Nov 28 21:35:33 +0000 2017
X-GM-THRID: 1585346786944774939
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread