In check_slab, s->name is passed incorrectly to the error
messages. It will cause confusing error messages if the object
check fails. This patch fix this bug by removing s->name.
Signed-off-by: Min-Hua Chen <[email protected]>
---
mm/slub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index ae7b9f1..5da9f9f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -849,12 +849,12 @@ static int check_slab(struct kmem_cache *s,
struct page *page)
maxobj = order_objects(compound_order(page), s->size, s->reserved);
if (page->objects > maxobj) {
slab_err(s, page, "objects %u > max %u",
- s->name, page->objects, maxobj);
+ page->objects, maxobj);
return 0;
}
if (page->inuse > page->objects) {
slab_err(s, page, "inuse %u > max %u",
- s->name, page->inuse, page->objects);
+ page->inuse, page->objects);
return 0;
}
/* Slab_pad_check fixes things up after itself */
--
1.7.10.4
On Mon, 24 Nov 2014, Min-Hua Chen wrote:
> In check_slab, s->name is passed incorrectly to the error
> messages. It will cause confusing error messages if the object
> check fails. This patch fix this bug by removing s->name.
I have seen a patch like thios before.
Acked-by: Christoph Lameter <[email protected]>
2014-11-24 20:17 GMT+03:00 Christoph Lameter <[email protected]>:
> On Mon, 24 Nov 2014, Min-Hua Chen wrote:
>
>> In check_slab, s->name is passed incorrectly to the error
>> messages. It will cause confusing error messages if the object
>> check fails. This patch fix this bug by removing s->name.
>
> I have seen a patch like thios before.
>
It's in -mm already
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-fix-format-mismatches-in-slab_err-callers.patch
> Acked-by: Christoph Lameter <[email protected]>
>
On Mon, 24 Nov 2014, Andrey Ryabinin wrote:
> It's in -mm already
> http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-fix-format-mismatches-in-slab_err-callers.patch
>
Yeah, and the one in -mm isn't whitespace damaged. Since the issue has
existed for years, I don't think there's any rush in getting this in 3.18.