2017-03-01 10:53:58

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] Revert"x86/acpi: Enable MADT APIs to return disabled apicids"

On Mon, 20 Feb 2017, Dou Liyang wrote:

> After we never do the last mapping of "cpuid <-> nodeid" at booting time. we
> also no need to enable MADT APIs to return disabled apicid.
>
> So, The patch work for reverting the commit 8ad893faf2:
> "x86/acpi: Enable MADT APIs to return disabled apicids"

Again, this changelog is confusing. A simple:

Remove the leftovers of the boot time 'cpuid <-> nodeid' mapping approach.

would be sufficient and entirely clear.

Thanks,

tglx


2017-03-02 08:17:43

by Dou Liyang

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] Revert"x86/acpi: Enable MADT APIs to return disabled apicids"

Hi tglx,

At 03/01/2017 06:52 PM, Thomas Gleixner wrote:
> On Mon, 20 Feb 2017, Dou Liyang wrote:
>
>> After we never do the last mapping of "cpuid <-> nodeid" at booting time. we
>> also no need to enable MADT APIs to return disabled apicid.
>>
>> So, The patch work for reverting the commit 8ad893faf2:
>> "x86/acpi: Enable MADT APIs to return disabled apicids"
>
> Again, this changelog is confusing. A simple:
>
> Remove the leftovers of the boot time 'cpuid <-> nodeid' mapping approach.
>
> would be sufficient and entirely clear.
>

Yes, I see, I will rewrite it in next version.

Thanks.

Liyang.

> Thanks,
>
> tglx
>
>
>
>