2017-03-17 13:37:40

by Chandra Annamaneni

Subject: [PATCH] Fix style warnings in drivers/staging/most/aim-v4l2

Enclosed is a patch to the file video.c. It only fixes style warning
flagged by checkpatch.pl.

Please let me know if anything else needs to be done.

Signed-off-by: Chandra Annamaneni <[email protected]>

Thanks.
Chandra

diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c
index e074841..59e861e 100644
--- a/drivers/staging/most/aim-v4l2/video.c
+++ b/drivers/staging/most/aim-v4l2/video.c
@@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
struct most_video_dev *mdev = video_drvdata(filp);
struct aim_fh *fh;

- v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
+ v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

switch (vdev->vfl_type) {
case VFL_TYPE_GRABBER:
@@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
struct most_video_dev *mdev = fh->mdev;
struct mbo *mbo, *tmp;

- v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
+ v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

/*
* We need to put MBOs back before we call most_stop_channel()
@@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void *priv, v4l2_std_id *norm)
struct aim_fh *fh = priv;
struct most_video_dev *mdev = fh->mdev;

- v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
+ v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

*norm = V4L2_STD_UNKNOWN;
return 0;
@@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, void *priv, unsigned int index)
struct aim_fh *fh = priv;
struct most_video_dev *mdev = fh->mdev;

- v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index);
+ v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);

if (index >= V4L2_AIM_MAX_INPUT)
return -EINVAL;
@@ -441,7 +441,7 @@ static int aim_register_videodev(struct most_video_dev *mdev)
{
int ret;

- v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
+ v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

init_waitqueue_head(&mdev->wait_data);

@@ -471,7 +471,7 @@ static int aim_register_videodev(struct most_video_dev *mdev)

static void aim_unregister_videodev(struct most_video_dev *mdev)
{
- v4l2_info(&mdev->v4l2_dev, "aim_unregister_videodev()\n");
+ v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

video_unregister_device(mdev->vdev);
}

2017-03-17 15:18:09

by Dan Carpenter

Subject: Re: [PATCH] Fix style warnings in drivers/staging/most/aim-v4l2

Fix the patch prefix. It should be:

[PATCH v2] Staging: most: use __func__ instead of the function name

On Fri, Mar 17, 2017 at 06:36:18AM -0700, Chandra Annamaneni wrote:
>
>
> Enclosed is a patch to the file video.c. It only fixes style warning
> flagged by checkpatch.pl.
>
> Please let me know if anything else needs to be done.
>
> Signed-off-by: Chandra Annamaneni <[email protected]>on
>
> Thanks.
> Chandra

This is an email but we want a patch description. Look at other
messages to the list for how it's done. Otherwise the patch looks OK.

regards,
dan carpenter