2018-01-13 15:58:34

by Himanshu Jha

Subject: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

Remove the unncessary part of the warning reported, in the report
mode, so that a single warning produced does not exceed more than line
and hence improve readability of the warnings produced in the subsequent
reports to a file.

Signed-off-by: Himanshu Jha <[email protected]>
---
scripts/coccinelle/free/ifnullfree.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/free/ifnullfree.cocci b/scripts/coccinelle/free/ifnullfree.cocci
index 14a4cd9..a70e123 100644
--- a/scripts/coccinelle/free/ifnullfree.cocci
+++ b/scripts/coccinelle/free/ifnullfree.cocci
@@ -55,5 +55,5 @@ cocci.print_main("NULL check before that freeing function is not needed", p)
p << r.p;
@@

-msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
+msg = "WARNING: NULL check before some freeing functions is not needed."
coccilib.report.print_report(p[0], msg)
--
2.7.4

2018-01-13 16:28:19

by Julia Lawall

Subject: Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

On Sat, 13 Jan 2018, Himanshu Jha wrote:

> Remove the unncessary part of the warning reported, in the report
> mode, so that a single warning produced does not exceed more than line
> and hence improve readability of the warnings produced in the subsequent
> reports to a file.
>
> Signed-off-by: Himanshu Jha <[email protected]>

Acked-by: Julia Lawall <[email protected]>

> ---
> scripts/coccinelle/free/ifnullfree.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/free/ifnullfree.cocci b/scripts/coccinelle/free/ifnullfree.cocci
> index 14a4cd9..a70e123 100644
> --- a/scripts/coccinelle/free/ifnullfree.cocci
> +++ b/scripts/coccinelle/free/ifnullfree.cocci
> @@ -55,5 +55,5 @@ cocci.print_main("NULL check before that freeing function is not needed", p)
> p << r.p;
> @@
>
> -msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
> +msg = "WARNING: NULL check before some freeing functions is not needed."
> coccilib.report.print_report(p[0], msg)
> --
> 2.7.4
>
>

2018-01-16 14:35:25

by Masahiro Yamada

Subject: Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

2018-01-14 0:58 GMT+09:00 Himanshu Jha <[email protected]>:
> Remove the unncessary part of the warning reported, in the report
> mode, so that a single warning produced does not exceed more than line
> and hence improve readability of the warnings produced in the subsequent
> reports to a file.
>
> Signed-off-by: Himanshu Jha <[email protected]>
> ---

Applied to linux-kbuild/misc. Thanks!

--
Best Regards
Masahiro Yamada