2015-08-03 03:09:37

by Christian Kujau

Subject: [PATCH] fallback to hostname in scripts/package/builddeb

Hi,

I happened to build a kernel with "make deb-pkg" on a machine with no
network connectivity, but this failed with:

[...]
INSTALL debian/headertmp/usr/include/asm/ (65 files)
hostname: Name or service not known
../scripts/package/Makefile:90: recipe for target 'deb-pkg' failed
make[2]: *** [deb-pkg] Error 1

In scripts/package/builddeb it tries to construct an email address (that
can be queried in /proc/version later on) but with no network,
the "hostname -f" fails. The following patch falls back to just use the
shortname if we cannot determine our FQDN.

Signed-off-by: Christian Kujau <[email protected]>

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 88dbf23..7de1d1c 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -206,7 +206,7 @@ if [ -n "$DEBEMAIL" ]; then
elif [ -n "$EMAIL" ]; then
email=$EMAIL
else
- email=$(id -nu)@$(hostname -f)
+ email=$(id -nu)@$(hostname -f 2>/dev/null || hostname)
fi
if [ -n "$DEBFULLNAME" ]; then
name=$DEBFULLNAME


--
BOFH excuse #334:

50% of the manual is in .pdf readme files

2015-08-04 11:43:11

by Michal Marek

Subject: Re: [PATCH] fallback to hostname in scripts/package/builddeb

On Sun, Aug 02, 2015 at 08:03:26PM -0700, Christian Kujau wrote:
> Hi,
>
> I happened to build a kernel with "make deb-pkg" on a machine with no
> network connectivity, but this failed with:
>
> [...]
> INSTALL debian/headertmp/usr/include/asm/ (65 files)
> hostname: Name or service not known
> ../scripts/package/Makefile:90: recipe for target 'deb-pkg' failed
> make[2]: *** [deb-pkg] Error 1
>
> In scripts/package/builddeb it tries to construct an email address (that
> can be queried in /proc/version later on) but with no network,
> the "hostname -f" fails. The following patch falls back to just use the
> shortname if we cannot determine our FQDN.
>
> Signed-off-by: Christian Kujau <[email protected]>

Applied to kbuild.git#misc, thanks.

Michal