2019-02-11 12:33:08

by Qian Cai

Subject: [PATCH] slub: remove an unused addr argument

"addr" function argument is not used in alloc_consistency_checks() at
all, so remove it.

Fixes: becfda68abca ("slub: convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS")
Signed-off-by: Qian Cai <[email protected]>
---
mm/slub.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 075ebc529788..4a61959e1887 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1077,8 +1077,7 @@ static void setup_object_debug(struct kmem_cache *s, struct page *page,
}

static inline int alloc_consistency_checks(struct kmem_cache *s,
- struct page *page,
- void *object, unsigned long addr)
+ struct page *page, void *object)
{
if (!check_slab(s, page))
return 0;
@@ -1099,7 +1098,7 @@ static noinline int alloc_debug_processing(struct kmem_cache *s,
void *object, unsigned long addr)
{
if (s->flags & SLAB_CONSISTENCY_CHECKS) {
- if (!alloc_consistency_checks(s, page, object, addr))
+ if (!alloc_consistency_checks(s, page, object))
goto bad;
}

--
2.17.2 (Apple Git-113)

2019-02-11 22:07:10

by David Rientjes

Subject: Re: [PATCH] slub: remove an unused addr argument

On Mon, 11 Feb 2019, Qian Cai wrote:

> "addr" function argument is not used in alloc_consistency_checks() at
> all, so remove it.
>
> Fixes: becfda68abca ("slub: convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS")
> Signed-off-by: Qian Cai <[email protected]>

Acked-by: David Rientjes <[email protected]>