From: kbuild test robot <[email protected]>
PTR_ERR should normally access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 62c9c1442c8f ("j721e new machine driver wip")
Signed-off-by: kbuild test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---
tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
j721e-evm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/sound/soc/ti/j721e-evm.c
+++ b/sound/soc/ti/j721e-evm.c
@@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
parent = devm_clk_get(&pdev->dev, clk_name);
kfree(clk_name);
if (IS_ERR(parent)) {
- ret = PTR_ERR(clocks->parent);
+ ret = PTR_ERR(parent);
if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, "failed to acquire %s': %d\n",
prefix, ret);
@@ -299,7 +299,7 @@ static int j721e_get_clocks(struct platf
parent = devm_clk_get(&pdev->dev, clk_name);
kfree(clk_name);
if (IS_ERR(parent)) {
- ret = PTR_ERR(clocks->parent);
+ ret = PTR_ERR(parent);
if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, "failed to acquire %s': %d\n",
prefix, ret);
On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
> :::::: branch date: 20 hours ago
> :::::: commit date: 20 hours ago
>
> j721e-evm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/sound/soc/ti/j721e-evm.c
> +++ b/sound/soc/ti/j721e-evm.c
> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
This file isn't upstream, it's only in the TI BSP.
On 09/08/2019 15.31, Mark Brown wrote:
> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>
>> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
>> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
>> :::::: branch date: 20 hours ago
>> :::::: commit date: 20 hours ago
>>
>> j721e-evm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- a/sound/soc/ti/j721e-evm.c
>> +++ b/sound/soc/ti/j721e-evm.c
>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>
> This file isn't upstream, it's only in the TI BSP.
Yes, it is not upstream, but the fix is valid.
Julia: is it possible to direct these notifications only to me from
https://github.com/omap-audio/linux-audio.git ?
It mostly carries TI BSP stuff and my various for upstream branches nowdays.
- P?ter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>
>
> On 09/08/2019 15.31, Mark Brown wrote:
> > On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
> >
> >> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
> >> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
> >> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
> >> :::::: branch date: 20 hours ago
> >> :::::: commit date: 20 hours ago
> >>
> >> j721e-evm.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --- a/sound/soc/ti/j721e-evm.c
> >> +++ b/sound/soc/ti/j721e-evm.c
> >> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
> >
> > This file isn't upstream, it's only in the TI BSP.
>
> Yes, it is not upstream, but the fix is valid.
>
> Julia: is it possible to direct these notifications only to me from
> https://github.com/omap-audio/linux-audio.git ?
>
> It mostly carries TI BSP stuff and my various for upstream branches nowdays.
Please discuss it with the kbuild people. They should be able to set it
up as you want.
You can try [email protected]
julia
Hi Peter,
We have updated to only send the reports to you, please see
https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio
Best Regards,
Rong Chen
On 8/9/19 9:21 PM, Julia Lawall wrote:
>
> On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>
>>
>> On 09/08/2019 15.31, Mark Brown wrote:
>>> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>>>
>>>> tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
>>>> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>>>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip
>>>> :::::: branch date: 20 hours ago
>>>> :::::: commit date: 20 hours ago
>>>>
>>>> j721e-evm.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> --- a/sound/soc/ti/j721e-evm.c
>>>> +++ b/sound/soc/ti/j721e-evm.c
>>>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>>> This file isn't upstream, it's only in the TI BSP.
>> Yes, it is not upstream, but the fix is valid.
>>
>> Julia: is it possible to direct these notifications only to me from
>> https://github.com/omap-audio/linux-audio.git ?
>>
>> It mostly carries TI BSP stuff and my various for upstream branches nowdays.
> Please discuss it with the kbuild people. They should be able to set it
> up as you want.
>
> You can try [email protected]
>
> julia
> _______________________________________________
> kbuild-all mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/kbuild-all
Hi Chen,
On 20/08/2019 11.41, Rong Chen wrote:
> Hi Peter,
>
> We have updated to only send the reports to you, please see
> https://github.com/intel/lkp-tests/blob/master/repo/linux/omap-audio
Thank you very much!
>
> Best Regards,
> Rong Chen
>
> On 8/9/19 9:21 PM, Julia Lawall wrote:
>>
>> On Fri, 9 Aug 2019, Peter Ujfalusi wrote:
>>
>>>
>>> On 09/08/2019 15.31, Mark Brown wrote:
>>>> On Fri, Aug 09, 2019 at 12:30:46PM +0200, Julia Lawall wrote:
>>>>
>>>>> tree: https://github.com/omap-audio/linux-audio
>>>>> peter/ti-linux-4.19.y/wip
>>>>> head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a
>>>>> commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new
>>>>> machine driver wip
>>>>> :::::: branch date: 20 hours ago
>>>>> :::::: commit date: 20 hours ago
>>>>>
>>>>> j721e-evm.c | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> --- a/sound/soc/ti/j721e-evm.c
>>>>> +++ b/sound/soc/ti/j721e-evm.c
>>>>> @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf
>>>> This file isn't upstream, it's only in the TI BSP.
>>> Yes, it is not upstream, but the fix is valid.
>>>
>>> Julia: is it possible to direct these notifications only to me from
>>> https://github.com/omap-audio/linux-audio.git ?
>>>
>>> It mostly carries TI BSP stuff and my various for upstream branches
>>> nowdays.
>> Please discuss it with the kbuild people. They should be able to set it
>> up as you want.
>>
>> You can try [email protected]
>>
>> julia
>> _______________________________________________
>> kbuild-all mailing list
>> [email protected]
>> https://lists.01.org/mailman/listinfo/kbuild-all
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki