2019-09-10 18:54:04

by Julia Lawall

[permalink] [raw]
Subject: [PATCH] dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings

From: kbuild test robot <[email protected]>

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 7cff81f3886d ("dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms")
CC: Jassi Brar <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---

url: https://github.com/0day-ci/linux/commits/jassisinghbrar-gmail-com/Add-support-for-AHB-DMA-controller-on-Milbeaut-series/20190910-142047
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Please take the patch only if it's a positive warning. Thanks!

milbeaut-hdmac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -171,7 +171,6 @@ static irqreturn_t milbeaut_hdmac_interr
{
struct milbeaut_hdmac_chan *mc = dev_id;
struct milbeaut_hdmac_desc *md;
- irqreturn_t ret = IRQ_HANDLED;
u32 val;

spin_lock(&mc->vc.lock);
@@ -201,7 +200,7 @@ static irqreturn_t milbeaut_hdmac_interr

out:
spin_unlock(&mc->vc.lock);
- return ret;
+ return IRQ_HANDLED;
}

static void milbeaut_hdmac_free_chan_resources(struct dma_chan *chan)
@@ -289,7 +288,6 @@ static int milbeaut_hdmac_terminate_all(
struct virt_dma_chan *vc = to_virt_chan(chan);
struct milbeaut_hdmac_chan *mc = to_milbeaut_hdmac_chan(vc);
unsigned long flags;
- int ret = 0;
u32 val;

LIST_HEAD(head);
@@ -311,7 +309,7 @@ static int milbeaut_hdmac_terminate_all(

vchan_dma_desc_free_list(vc, &head);

- return ret;
+ return 0;
}

static void milbeaut_hdmac_synchronize(struct dma_chan *chan)