2019-09-17 20:33:12

by Qian Cai

[permalink] [raw]
Subject: [PATCH] mm/slub: fix -Wunused-function compiler warnings

tid_to_cpu() and tid_to_event() are only used in note_cmpxchg_failure()
when SLUB_DEBUG_CMPXCHG=y, so when SLUB_DEBUG_CMPXCHG=n by default,
Clang will complain that those unused functions.

Signed-off-by: Qian Cai <[email protected]>
---
mm/slub.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/mm/slub.c b/mm/slub.c
index 8834563cdb4b..49739f005b4f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2004,6 +2004,7 @@ static inline unsigned long next_tid(unsigned long tid)
return tid + TID_STEP;
}

+#ifdef SLUB_DEBUG_CMPXCHG
static inline unsigned int tid_to_cpu(unsigned long tid)
{
return tid % TID_STEP;
@@ -2013,6 +2014,7 @@ static inline unsigned long tid_to_event(unsigned long tid)
{
return tid / TID_STEP;
}
+#endif

static inline unsigned int init_tid(int cpu)
{
--
1.8.3.1


2019-09-18 00:33:45

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH] mm/slub: fix -Wunused-function compiler warnings

On Tue, 17 Sep 2019, Qian Cai wrote:

> tid_to_cpu() and tid_to_event() are only used in note_cmpxchg_failure()
> when SLUB_DEBUG_CMPXCHG=y, so when SLUB_DEBUG_CMPXCHG=n by default,
> Clang will complain that those unused functions.
>
> Signed-off-by: Qian Cai <[email protected]>

Acked-by: David Rientjes <[email protected]>

Subject: Re: [PATCH] mm/slub: fix -Wunused-function compiler warnings

On Tue, 17 Sep 2019, David Rientjes wrote:

> Acked-by: David Rientjes <[email protected]>

Ditto

Subject: Re: [PATCH] mm/slub: fix -Wunused-function compiler warnings

On Tue, 17 Sep 2019, David Rientjes wrote:

> On Tue, 17 Sep 2019, Qian Cai wrote:
>
> > tid_to_cpu() and tid_to_event() are only used in note_cmpxchg_failure()
> > when SLUB_DEBUG_CMPXCHG=y, so when SLUB_DEBUG_CMPXCHG=n by default,
> > Clang will complain that those unused functions.
> >
> > Signed-off-by: Qian Cai <[email protected]>
>
> Acked-by: David Rientjes <[email protected]>

Ditto