2019-10-09 19:44:16

by Jules Irenge

[permalink] [raw]
Subject: [PATCH] staging: qlge: correct misspelled word

Correct misspelled word " check
issued by checkpatch.pl tool:
"CHECK: serveral may be misspelled - perhaps several?".

Signed-off-by: Jules Irenge <[email protected]>
---
drivers/staging/qlge/qlge_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 086f067fd899..097fab7b4287 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -354,7 +354,7 @@ static int ql_get_xgmac_regs(struct ql_adapter *qdev, u32 *buf,

for (i = PAUSE_SRC_LO; i < XGMAC_REGISTER_END; i += 4, buf++) {
/* We're reading 400 xgmac registers, but we filter out
- * serveral locations that are non-responsive to reads.
+ * several locations that are non-responsive to reads.
*/
if ((i == 0x00000114) ||
(i == 0x00000118) ||
--
2.21.0


2019-10-09 20:53:04

by Julia Lawall

[permalink] [raw]
Subject: Re: [Outreachy kernel] [PATCH] staging: qlge: correct misspelled word



On Wed, 9 Oct 2019, Jules Irenge wrote:

> Correct misspelled word " check

Why is there a " in the above line?

You don't need to put a newline after check.

> issued by checkpatch.pl tool:
> "CHECK: serveral may be misspelled - perhaps several?".

It's not reall necessary to give the checkpatch message in this case,
although it is good to acknowledge checkpatch. You could say something
like:

Fix a misspelling of "several" detected by checkpatch.

julia

> Signed-off-by: Jules Irenge <[email protected]>
> ---
> drivers/staging/qlge/qlge_dbg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 086f067fd899..097fab7b4287 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -354,7 +354,7 @@ static int ql_get_xgmac_regs(struct ql_adapter *qdev, u32 *buf,
>
> for (i = PAUSE_SRC_LO; i < XGMAC_REGISTER_END; i += 4, buf++) {
> /* We're reading 400 xgmac registers, but we filter out
> - * serveral locations that are non-responsive to reads.
> + * several locations that are non-responsive to reads.
> */
> if ((i == 0x00000114) ||
> (i == 0x00000118) ||
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191009194115.5513-1-jbi.octave%40gmail.com.
>