2019-10-15 12:15:06

by Wambui Karuga

Subject: [PATCH] staging: rtl8723bs: remove casts to pointers in kfree

Remove unnecessary casts in pointer types passed to kfree.

Signed-off-by: Wambui Karuga <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 3030ae5b6b6d..71fcb466019a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2155,7 +2155,7 @@ sint rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)

psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
if (!psetauthparm) {
- kfree((unsigned char *)pcmd);
+ kfree(pcmd);
res = _FAIL;
goto exit;
}
@@ -2238,7 +2238,7 @@ sint rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, s
if (enqueue) {
pcmd = rtw_zmalloc(sizeof(struct cmd_obj));
if (!pcmd) {
- kfree((unsigned char *)psetkeyparm);
+ kfree(psetkeyparm);
res = _FAIL; /* try again */
goto exit;
}
--
2.23.0

2019-10-15 12:15:28

by Julia Lawall

Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: remove casts to pointers in kfree

On Tue, 15 Oct 2019, Wambui Karuga wrote:

> Remove unnecessary casts in pointer types passed to kfree.
>
> Signed-off-by: Wambui Karuga <[email protected]>

Acked-by: Julia Lawall <[email protected]>

> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 3030ae5b6b6d..71fcb466019a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2155,7 +2155,7 @@ sint rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)
>
> psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
> if (!psetauthparm) {
> - kfree((unsigned char *)pcmd);
> + kfree(pcmd);
> res = _FAIL;
> goto exit;
> }
> @@ -2238,7 +2238,7 @@ sint rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, s
> if (enqueue) {
> pcmd = rtw_zmalloc(sizeof(struct cmd_obj));
> if (!pcmd) {
> - kfree((unsigned char *)psetkeyparm);
> + kfree(psetkeyparm);
> res = _FAIL; /* try again */
> goto exit;
> }
> --
> 2.23.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191015112637.20824-1-wambui.karugax%40gmail.com.
>