2019-11-03 19:31:24

by Markus Elfring

Subject: [PATCH] Coccinelle: zalloc-simple: Adjust a message construction

From: Markus Elfring <[email protected]>
Date: Sun, 3 Nov 2019 20:00:30 +0100

* Simplify a message construction in a Python script rule
for the semantic patch language.

* Delete also a duplicate space character then.

Fixes: dfd32cad146e3624970eee9329e99d2c6ef751b3 ("dma-mapping: remove dma_zalloc_coherent()")
Signed-off-by: Markus Elfring <[email protected]>
---
scripts/coccinelle/api/alloc/zalloc-simple.cocci | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
index 26cda3f48f01..c14eae1f3010 100644
--- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
+++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
@@ -217,8 +217,10 @@ p << r2.p;
x << r2.x;
@@

-msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory, so memset is not needed" % (x)
-coccilib.report.print_report(p[0], msg)
+coccilib.report.print_report(p[0],
+ "WARNING: dma_alloc_coherent use in "
+ + x
+ + " already zeroes out memory. Thus memset is not needed.")

//-----------------------------------------------------------------
@r3 depends on org || report@
--
2.23.0

2019-11-03 19:41:32

by Julia Lawall

Subject: Re: [PATCH] Coccinelle: zalloc-simple: Adjust a message construction

On Sun, 3 Nov 2019, Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Sun, 3 Nov 2019 20:00:30 +0100
>
> * Simplify a message construction in a Python script rule
> for the semantic patch language.

The benefit is what?

julia

>
> * Delete also a duplicate space character then.
>
> Fixes: dfd32cad146e3624970eee9329e99d2c6ef751b3 ("dma-mapping: remove dma_zalloc_coherent()")
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> scripts/coccinelle/api/alloc/zalloc-simple.cocci | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> index 26cda3f48f01..c14eae1f3010 100644
> --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> @@ -217,8 +217,10 @@ p << r2.p;
> x << r2.x;
> @@
>
> -msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory, so memset is not needed" % (x)
> -coccilib.report.print_report(p[0], msg)
> +coccilib.report.print_report(p[0],
> + "WARNING: dma_alloc_coherent use in "
> + + x
> + + " already zeroes out memory. Thus memset is not needed.")
>
> //-----------------------------------------------------------------
> @r3 depends on org || report@
> --
> 2.23.0
>
>

2019-11-03 21:06:50

by Markus Elfring

Subject: Re: Coccinelle: zalloc-simple: Adjust a message construction

>> * Simplify a message construction in a Python script rule
>> for the semantic patch language.
>
> The benefit is what?

The avoidance to store the shown string in the extra Python variable “msg”.


>> * Delete also a duplicate space character then.

I find the proposed wording a bit nicer, don't you?

Regards,
Markus