2019-11-17 11:15:52

by Julia Lawall

Subject: [PATCH] drivers/soc: fix semicolon.cocci warnings

From: kbuild test robot <[email protected]>

Remove unneeded semicolons.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: eeb5d52f36e5 ("drivers/soc: Add Aspeed XDMA Engine Driver")
CC: Eddie James <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>

---

url: https://github.com/0day-ci/linux/commits/Eddie-James/Aspeed-Add-SCU-interrupt-controller-and-XDMA-engine-drivers/20191110-064846
base: https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git for-next
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago

aspeed-xdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/soc/aspeed/aspeed-xdma.c
+++ b/drivers/soc/aspeed/aspeed-xdma.c
@@ -607,7 +607,7 @@ static int aspeed_xdma_init(struct aspee

scu = syscon_regmap_lookup_by_compatible("aspeed,ast2600-scu");
break;
- };
+ }

if (!scu) {
dev_err(ctx->dev, "Failed to grab SCU regs.\n");
@@ -735,7 +735,7 @@ static int aspeed_xdma_probe(struct plat
ctx->status_bits.ds_comp = XDMA_AST2600_STATUS_DS_COMP;
ctx->status_bits.ds_dirty = XDMA_AST2600_STATUS_DS_DIRTY;
break;
- };
+ }

ctx->dev = dev;
platform_set_drvdata(pdev, ctx);

2019-11-18 08:34:23

by Joel Stanley

Subject: Re: [PATCH] drivers/soc: fix semicolon.cocci warnings

Hello,

On Sun, 17 Nov 2019 at 11:13, Julia Lawall <[email protected]> wrote:
>
> From: kbuild test robot <[email protected]>
>
> Remove unneeded semicolons.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: eeb5d52f36e5 ("drivers/soc: Add Aspeed XDMA Engine Driver")
> CC: Eddie James <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
>
> url: https://github.com/0day-ci/linux/commits/Eddie-James/Aspeed-Add-SCU-interrupt-controller-and-XDMA-engine-drivers/20191110-064846
> base: https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git for-next

I found this confusing, as the branch doesn't contain the patch you're
referring to.

Cheers,

Joel



> :::::: branch date: 7 days ago
> :::::: commit date: 7 days ago
>
> aspeed-xdma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/soc/aspeed/aspeed-xdma.c
> +++ b/drivers/soc/aspeed/aspeed-xdma.c
> @@ -607,7 +607,7 @@ static int aspeed_xdma_init(struct aspee
>
> scu = syscon_regmap_lookup_by_compatible("aspeed,ast2600-scu");
> break;
> - };
> + }
>
> if (!scu) {
> dev_err(ctx->dev, "Failed to grab SCU regs.\n");
> @@ -735,7 +735,7 @@ static int aspeed_xdma_probe(struct plat
> ctx->status_bits.ds_comp = XDMA_AST2600_STATUS_DS_COMP;
> ctx->status_bits.ds_dirty = XDMA_AST2600_STATUS_DS_DIRTY;
> break;
> - };
> + }
>
> ctx->dev = dev;
> platform_set_drvdata(pdev, ctx);