2020-01-04 20:45:15

by Julia Lawall

Subject: [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

From: kbuild test robot <[email protected]>

Remove dev_err() messages after platform_get_irq*() failures.
Line 450 is redundant because platform_get_irq() already prints
an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
Signed-off-by: kbuild test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>

---

tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next
head: 80805774fc354f9ae7755a8e649a01dedfd0dcf8
commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

mmp_ctrl.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
ret = -ENOENT;
goto failed;
}

2020-01-07 16:15:56

by Daniel Vetter

Subject: Re: [PATCH] video: fbdev: mmp: fix platform_get_irq.cocci warnings

On Sat, Jan 04, 2020 at 09:43:31PM +0100, Julia Lawall wrote:
> From: kbuild test robot <[email protected]>
>
> Remove dev_err() messages after platform_get_irq*() failures.
> Line 450 is redundant because platform_get_irq() already prints
> an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Fixes: dd90e9ae55a1 ("video: fbdev: mmp: add COMPILE_TEST support")
> Signed-off-by: kbuild test robot <[email protected]>
> Signed-off-by: Julia Lawall <[email protected]>

Applied to drm-misc-next, thanks for your patch.
-Daniel

>
> ---
>
> tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> head: 80805774fc354f9ae7755a8e649a01dedfd0dcf8
> commit: dd90e9ae55a1e7efd3ac036afe9f7ae7bb64d39d [2/16] video: fbdev: mmp: add COMPILE_TEST support
> :::::: branch date: 11 hours ago
> :::::: commit date: 11 hours ago
>
> mmp_ctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_d
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
> ret = -ENOENT;
> goto failed;
> }
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch