LinuxLists.cc - sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num

2020-02-06 10:51:15

Subject: sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
d1857bcbf007275704d8
91ad94768c9dc2b7bb3d ASoC: Intel: boards: fix incorrect HDMI Kconfig dependency
(attached as .config)
7.5.0-3) 7.5.0
aa2b4a59871a0528bccb91ad94768c9dc2b7bb3d
attached .config to linux build tree
kindly add following tag
test robot <[email protected]>
prefixed by >>):
in function `intel_not_share_assigned_cvt':
undefined reference to `snd_hda_get_num_devices'
atch_hdmi.c:1098: undefined reference to `snd_hda_get_dev_select'
atch_hdmi.c:1099: undefined reference to `snd_hda_set_dev_select'
undefined reference to `snd_hda_set_dev_select'
in function `check_non_pcm_per_cvt':
undefined reference to `snd_hda_spdif_out_of_nid'
in function `reprogram_jack_detect':
undefined reference to `snd_hda_jack_tbl_get_mst'
atch_hdmi.c:2503: undefined reference to `snd_hda_jack_detect_enable'
in function `generic_hdmi_build_pcms':
undefined reference to `snd_hda_codec_pcm_new'
in function `generic_hdmi_playback_pcm_cleanup':
undefined reference to `__snd_hda_codec_cleanup_stream'
in function `generic_hdmi_build_jack':
undefined reference to `is_jack_detectable'
atch_hdmi.c:2217: undefined reference to `snd_hda_jack_add_kctl_mst'
atch_hdmi.c:2222: undefined reference to `snd_hda_jack_tbl_get_mst'
in function `hdmi_pin_get_eld':
undefined reference to `snd_hda_set_dev_select'
in function `intel_haswell_enable_all_pins':
undefined reference to `snd_hda_codec_update_widgets'
in function `simple_hdmi_unsol_event':
undefined reference to `snd_hda_jack_set_dirty_all'
atch_hdmi.c:2979: undefined reference to `snd_hda_jack_report_sync'
in function `simple_playback_pcm_prepare':
undefined reference to `snd_hda_multi_out_dig_prepare'
in function `simple_playback_pcm_close':
undefined reference to `snd_hda_multi_out_dig_close'
in function `simple_playback_pcm_open':
undefined reference to `snd_hda_multi_out_dig_open'
in function `nvhdmi_7x_init_8ch':
undefined reference to `snd_hda_sequence_write'
in function `nvhdmi_7x_init_2ch':
undefined reference to `snd_hda_sequence_write'
in function `hdmi_pcm_open':
undefined reference to `snd_hda_set_dev_select'
atch_hdmi.c:1265: undefined reference to `snd_hda_spdif_ctls_assign'
/> 2013-10-24 921
2013-10-24 922 static int hdmi_setup_stream(struct hda_codec *codec, hda_nid_t cvt_nid,
2019-11-19 923 hda_nid_t pin_nid, int dev_id,
2019-11-19 924 u32 stream_tag, int format)
2013-10-24 925 {
2013-10-24 926 struct hdmi_spec *spec = codec->spec;
Periyasamy 2017-09-19 927 unsigned int param;
2013-10-24 928 int err;
2013-10-24 929
2019-11-19 930 err = spec->ops.pin_hbr_setup(codec, pin_nid, dev_id,
2019-11-19 931 is_hbr_format(format));
2013-10-24 932
2013-10-24 933 if (err) {
2014-02-25 934 codec_dbg(codec, "hdmi_setup_stream: HBR is not supported\n");
2013-10-24 935 return err;
2010-08-03 936 }
2010-03-08 937
2019-11-11 938 if (spec->intel_hsw_fixup) {
Periyasamy 2017-09-19 939
Periyasamy 2017-09-19 940 /*
Periyasamy 2017-09-19 941 * on recent platforms IEC Coding Type is required for HBR
Periyasamy 2017-09-19 942 * support, read current Digital Converter settings and set
Periyasamy 2017-09-19 943 * ICT bitfield if needed.
Periyasamy 2017-09-19 944 */
Periyasamy 2017-09-19 945 param = snd_hda_codec_read(codec, cvt_nid, 0,
Periyasamy 2017-09-19 946 AC_VERB_GET_DIGI_CONVERT_1, 0);
Periyasamy 2017-09-19 947
Periyasamy 2017-09-19 948 param = (param >> 16) & ~(AC_DIG3_ICT);
Periyasamy 2017-09-19 949
Periyasamy 2017-09-19 950 /* on recent platforms ICT mode is required for HBR support */
Periyasamy 2017-09-19 951 if (is_hbr_format(format))
Periyasamy 2017-09-19 952 param |= 0x1;
Periyasamy 2017-09-19 953
Periyasamy 2017-09-19 954 snd_hda_codec_write(codec, cvt_nid, 0,
Periyasamy 2017-09-19 955 AC_VERB_SET_DIGI_CONVERT_3, param);
Periyasamy 2017-09-19 956 }
Periyasamy 2017-09-19 957
2011-06-01 @958 snd_hda_codec_setup_stream(codec, cvt_nid, stream_tag, 0, format);
2010-08-03 959 return 0;
2010-03-08 960 }
2010-03-08 961
2015-12-16 962 /* Try to find an available converter
2015-12-16 963 * If pin_idx is less then zero, just try to find an available converter.
2015-12-16 964 * Otherwise, try to find an available converter and get the cvt mux index
2015-12-16 965 * of the pin.
2015-12-16 966 */
2013-06-18 967 static int hdmi_choose_cvt(struct hda_codec *codec,
2016-03-21 968 int pin_idx, int *cvt_id)
2010-08-13 969 {
2010-08-13 970 struct hdmi_spec *spec = codec->spec;
2011-06-01 971 struct hdmi_spec_per_pin *per_pin;
2011-06-01 972 struct hdmi_spec_per_cvt *per_cvt = NULL;
2013-06-18 973 int cvt_idx, mux_idx = 0;
2010-08-13 974
2015-12-16 975 /* pin_idx < 0 means no pin will be bound to the converter */
2015-12-16 976 if (pin_idx < 0)
2015-12-16 977 per_pin = NULL;
2015-12-16 978 else
2013-03-13 979 per_pin = get_pin(spec, pin_idx);
2011-06-01 980
2011-06-01 981 /* Dynamically assign converter to stream */
2011-06-01 982 for (cvt_idx = 0; cvt_idx < spec->num_cvts; cvt_idx++) {
2013-03-13 983 per_cvt = get_cvt(spec, cvt_idx);
2011-06-01 984
2011-06-01 985 /* Must not already be assigned */
2011-06-01 986 if (per_cvt->assigned)
2011-06-01 987 continue;
2015-12-16 988 if (per_pin == NULL)
2015-12-16 989 break;
2011-06-01 990 /* Must be in pin's mux's list of converters */
2011-06-01 991 for (mux_idx = 0; mux_idx < per_pin->num_mux_nids; mux_idx++)
2011-06-01 992 if (per_pin->mux_nids[mux_idx] == per_cvt->cvt_nid)
2011-06-01 993 break;
2011-06-01 994 /* Not in mux list */
2011-06-01 995 if (mux_idx == per_pin->num_mux_nids)
2011-06-01 996 continue;
2011-06-01 997 break;
2011-06-01 998 }
2013-06-18 999
2011-06-01 1000 /* No free converters */
2011-06-01 1001 if (cvt_idx == spec->num_cvts)
2015-12-16 1002 return -EBUSY;
2010-08-13 1003
2015-12-16 1004 if (per_pin != NULL)
2014-03-20 1005 per_pin->mux_idx = mux_idx;
2014-03-20 1006
2013-06-18 1007 if (cvt_id)
2013-06-18 1008 *cvt_id = cvt_idx;
2013-06-18 1009
2013-06-18 1010 return 0;
2013-06-18 1011 }
2013-06-18 1012
2014-03-20 1013 /* Assure the pin select the right convetor */
2014-03-20 1014 static void intel_verify_pin_cvt_connect(struct hda_codec *codec,
2014-03-20 1015 struct hdmi_spec_per_pin *per_pin)
2014-03-20 1016 {
2014-03-20 1017 hda_nid_t pin_nid = per_pin->pin_nid;
2014-03-20 1018 int mux_idx, curr;
2014-03-20 1019
2014-03-20 1020 mux_idx = per_pin->mux_idx;
2014-03-20 1021 curr = snd_hda_codec_read(codec, pin_nid, 0,
2014-03-20 1022 AC_VERB_GET_CONNECT_SEL, 0);
2014-03-20 1023 if (curr != mux_idx)
2014-03-20 1024 snd_hda_codec_write_cache(codec, pin_nid, 0,
2014-03-20 1025 AC_VERB_SET_CONNECT_SEL,
2014-03-20 1026 mux_idx);
2014-03-20 1027 }
2014-03-20 1028
2015-12-16 1029 /* get the mux index for the converter of the pins
2015-12-16 1030 * converter's mux index is the same for all pins on Intel platform
2015-12-16 1031 */
2015-12-16 1032 static int intel_cvt_id_to_mux_idx(struct hdmi_spec *spec,
2015-12-16 1033 hda_nid_t cvt_nid)
2015-12-16 1034 {
2015-12-16 1035 int i;
2015-12-16 1036
2015-12-16 1037 for (i = 0; i < spec->num_cvts; i++)
2015-12-16 1038 if (spec->cvt_nids[i] == cvt_nid)
2015-12-16 1039 return i;
2015-12-16 1040 return -EINVAL;
2015-12-16 1041 }
2015-12-16 1042
2013-11-04 1043 /* Intel HDMI workaround to fix audio routing issue:
2013-11-04 1044 * For some Intel display codecs, pins share the same connection list.
2013-11-04 1045 * So a conveter can be selected by multiple pins and playback on any of these
2013-11-04 1046 * pins will generate sound on the external display, because audio flows from
2013-11-04 1047 * the same converter to the display pipeline. Also muting one pin may make
2013-11-04 1048 * other pins have no sound output.
2013-11-04 1049 * So this function assures that an assigned converter for a pin is not selected
2013-11-04 1050 * by any other pins.
2013-11-04 1051 */
2013-11-04 1052 static void intel_not_share_assigned_cvt(struct hda_codec *codec,
2017-01-12 1053 hda_nid_t pin_nid,
2017-01-12 1054 int dev_id, int mux_idx)
2013-06-18 1055 {
2013-06-18 1056 struct hdmi_spec *spec = codec->spec;
2015-03-03 1057 hda_nid_t nid;
2013-09-21 1058 int cvt_idx, curr;
2013-09-21 1059 struct hdmi_spec_per_cvt *per_cvt;
2017-01-12 1060 struct hdmi_spec_per_pin *per_pin;
2017-01-12 1061 int pin_idx;
2017-01-12 1062
2017-01-12 1063 /* configure the pins connections */
2017-01-12 1064 for (pin_idx = 0; pin_idx < spec->num_pins; pin_idx++) {
2017-01-12 1065 int dev_id_saved;
2017-01-12 1066 int dev_num;
2013-06-18 1067
2017-01-12 1068 per_pin = get_pin(spec, pin_idx);
2017-01-12 1069 /*
2017-01-12 1070 * pin not connected to monitor
2017-01-12 1071 * no need to operate on it
2017-01-12 1072 */
2017-01-12 1073 if (!per_pin->pcm)
2017-01-12 1074 continue;
2013-09-21 1075
2017-01-12 1076 if ((per_pin->pin_nid == pin_nid) &&
2017-01-12 1077 (per_pin->dev_id == dev_id))
2013-09-21 1078 continue;
2013-06-18 1079
2017-01-12 1080 /*
2017-01-12 1081 * if per_pin->dev_id >= dev_num,
2017-01-12 1082 * snd_hda_get_dev_select() will fail,
2017-01-12 1083 * and the following operation is unpredictable.
2017-01-12 1084 * So skip this situation.
2017-01-12 1085 */
2017-01-12 @1086 dev_num = snd_hda_get_num_devices(codec, per_pin->pin_nid) + 1;
2017-01-12 1087 if (per_pin->dev_id >= dev_num)
2013-06-18 1088 continue;
2013-06-18 1089
2017-01-12 1090 nid = per_pin->pin_nid;
2017-01-12 1091
2017-01-12 1092 /*
2017-01-12 1093 * Calling this function should not impact
2017-01-12 1094 * on the device entry selection
2017-01-12 1095 * So let's save the dev id for each pin,
2017-01-12 1096 * and restore it when return
2017-01-12 1097 */
2017-01-12 @1098 dev_id_saved = snd_hda_get_dev_select(codec, nid);
2017-01-12 @1099 snd_hda_set_dev_select(codec, nid, per_pin->dev_id);
2013-09-21 1100 curr = snd_hda_codec_read(codec, nid, 0,
2013-06-18 1101 AC_VERB_GET_CONNECT_SEL, 0);
2017-01-12 1102 if (curr != mux_idx) {
2017-01-12 1103 snd_hda_set_dev_select(codec, nid, dev_id_saved);
2013-09-21 1104 continue;
2017-01-12 1105 }
2017-01-12 1106
2013-06-18 1107
2013-09-21 1108 /* choose an unassigned converter. The conveters in the
2013-09-21 1109 * connection list are in the same order as in the codec.
2013-09-21 1110 */
2013-09-21 1111 for (cvt_idx = 0; cvt_idx < spec->num_cvts; cvt_idx++) {
2013-09-21 1112 per_cvt = get_cvt(spec, cvt_idx);
2013-09-21 1113 if (!per_cvt->assigned) {
2014-02-25 1114 codec_dbg(codec,
2014-02-25 1115 "choose cvt %d for pin nid %d\n",
2013-09-21 1116 cvt_idx, nid);
2013-09-21 1117 snd_hda_codec_write_cache(codec, nid, 0,
2013-06-18 1118 AC_VERB_SET_CONNECT_SEL,
2013-09-21 1119 cvt_idx);
2013-09-21 1120 break;
2013-09-21 1121 }
2013-06-18 1122 }
2017-01-12 1123 snd_hda_set_dev_select(codec, nid, dev_id_saved);
2013-06-18 1124 }
2013-06-18 1125 }
2013-06-18 1126
2015-12-16 1127 /* A wrapper of intel_not_share_asigned_cvt() */
2015-12-16 1128 static void intel_not_share_assigned_cvt_nid(struct hda_codec *codec,
2017-01-12 1129 hda_nid_t pin_nid, int dev_id, hda_nid_t cvt_nid)
2015-12-16 1130 {
2015-12-16 1131 int mux_idx;
2015-12-16 1132 struct hdmi_spec *spec = codec->spec;
2015-12-16 1133
2015-12-16 1134 /* On Intel platform, the mapping of converter nid to
2015-12-16 1135 * mux index of the pins are always the same.
2015-12-16 1136 * The pin nid may be 0, this means all pins will not
2015-12-16 1137 * share the converter.
2015-12-16 1138 */
2015-12-16 1139 mux_idx = intel_cvt_id_to_mux_idx(spec, cvt_nid);
2015-12-16 1140 if (mux_idx >= 0)
2017-01-12 1141 intel_not_share_assigned_cvt(codec, pin_nid, dev_id, mux_idx);
2015-12-16 1142 }
2015-12-16 1143
2016-03-21 1144 /* skeleton caller of pin_cvt_fixup ops */
2016-03-21 1145 static void pin_cvt_fixup(struct hda_codec *codec,
2016-03-21 1146 struct hdmi_spec_per_pin *per_pin,
2016-03-21 1147 hda_nid_t cvt_nid)
2016-03-21 1148 {
2016-03-21 1149 struct hdmi_spec *spec = codec->spec;
2016-03-21 1150
2016-03-21 1151 if (spec->ops.pin_cvt_fixup)
2016-03-21 1152 spec->ops.pin_cvt_fixup(codec, per_pin, cvt_nid);
2016-03-21 1153 }
2016-03-21 1154
2015-12-16 1155 /* called in hdmi_pcm_open when no pin is assigned to the PCM
2015-12-16 1156 * in dyn_pcm_assign mode.
2015-12-16 1157 */
2015-12-16 1158 static int hdmi_pcm_open_no_pin(struct hda_pcm_stream *hinfo,
2015-12-16 1159 struct hda_codec *codec,
2015-12-16 1160 struct snd_pcm_substream *substream)
2015-12-16 1161 {
2015-12-16 1162 struct hdmi_spec *spec = codec->spec;
2015-12-16 1163 struct snd_pcm_runtime *runtime = substream->runtime;
2015-12-16 1164 int cvt_idx, pcm_idx;
2015-12-16 1165 struct hdmi_spec_per_cvt *per_cvt = NULL;
2015-12-16 1166 int err;
2015-12-16 1167
2015-12-16 1168 pcm_idx = hinfo_to_pcm_index(codec, hinfo);
2015-12-16 1169 if (pcm_idx < 0)
2015-12-16 1170 return -EINVAL;
2015-12-16 1171
2016-03-21 1172 err = hdmi_choose_cvt(codec, -1, &cvt_idx);
2015-12-16 1173 if (err)
2015-12-16 1174 return err;
2015-12-16 1175
2015-12-16 1176 per_cvt = get_cvt(spec, cvt_idx);
2015-12-16 1177 per_cvt->assigned = 1;
2015-12-16 1178 hinfo->nid = per_cvt->cvt_nid;
2015-12-16 1179
2016-03-21 1180 pin_cvt_fixup(codec, NULL, per_cvt->cvt_nid);
2015-12-16 1181
2015-12-16 1182 set_bit(pcm_idx, &spec->pcm_in_use);
2015-12-16 1183 /* todo: setup spdif ctls assign */
2015-12-16 1184
2015-12-16 1185 /* Initially set the converter's capabilities */
2015-12-16 1186 hinfo->channels_min = per_cvt->channels_min;
2015-12-16 1187 hinfo->channels_max = per_cvt->channels_max;
2015-12-16 1188 hinfo->rates = per_cvt->rates;
2015-12-16 1189 hinfo->formats = per_cvt->formats;
2015-12-16 1190 hinfo->maxbps = per_cvt->maxbps;
2015-12-16 1191
2015-12-16 1192 /* Store the updated parameters */
2015-12-16 1193 runtime->hw.channels_min = hinfo->channels_min;
2015-12-16 1194 runtime->hw.channels_max = hinfo->channels_max;
2015-12-16 1195 runtime->hw.formats = hinfo->formats;
2015-12-16 1196 runtime->hw.rates = hinfo->rates;
2015-12-16 1197
2015-12-16 1198 snd_pcm_hw_constraint_step(substream->runtime, 0,
2015-12-16 1199 SNDRV_PCM_HW_PARAM_CHANNELS, 2);
2015-12-16 1200 return 0;
2015-12-16 1201 }
2015-12-16 1202
2013-06-18 1203 /*
2013-06-18 1204 * HDA PCM callbacks
2013-06-18 1205 */
2013-06-18 1206 static int hdmi_pcm_open(struct hda_pcm_stream *hinfo,
2013-06-18 1207 struct hda_codec *codec,
2013-06-18 1208 struct snd_pcm_substream *substream)
2013-06-18 1209 {
2013-06-18 1210 struct hdmi_spec *spec = codec->spec;
2013-06-18 1211 struct snd_pcm_runtime *runtime = substream->runtime;
2016-03-21 1212 int pin_idx, cvt_idx, pcm_idx;
2013-06-18 1213 struct hdmi_spec_per_pin *per_pin;
2013-06-18 1214 struct hdmi_eld *eld;
2013-06-18 1215 struct hdmi_spec_per_cvt *per_cvt = NULL;
2013-06-18 1216 int err;
2013-06-18 1217
2013-06-18 1218 /* Validate hinfo */
2015-12-16 1219 pcm_idx = hinfo_to_pcm_index(codec, hinfo);
2015-12-16 1220 if (pcm_idx < 0)
2015-12-16 1221 return -EINVAL;
2015-12-16 1222
2015-12-16 1223 mutex_lock(&spec->pcm_lock);
2014-02-25 1224 pin_idx = hinfo_to_pin_index(codec, hinfo);
2015-12-16 1225 if (!spec->dyn_pcm_assign) {
2015-12-16 1226 if (snd_BUG_ON(pin_idx < 0)) {
2018-07-12 1227 err = -EINVAL;
2018-07-12 1228 goto unlock;
2015-12-16 1229 }
2015-12-16 1230 } else {
2015-12-16 1231 /* no pin is assigned to the PCM
2015-12-16 1232 * PA need pcm open successfully when probe
2015-12-16 1233 */
2015-12-16 1234 if (pin_idx < 0) {
2015-12-16 1235 err = hdmi_pcm_open_no_pin(hinfo, codec, substream);
2018-07-12 1236 goto unlock;
2015-12-16 1237 }
2015-12-16 1238 }
2013-06-18 1239
2016-03-21 1240 err = hdmi_choose_cvt(codec, pin_idx, &cvt_idx);
2018-07-12 1241 if (err < 0)
2018-07-12 1242 goto unlock;
2013-06-18 1243
2013-06-18 1244 per_cvt = get_cvt(spec, cvt_idx);
2011-06-01 1245 /* Claim converter */
2011-06-01 1246 per_cvt->assigned = 1;
2015-12-16 1247
2015-12-16 1248 set_bit(pcm_idx, &spec->pcm_in_use);
2015-12-16 1249 per_pin = get_pin(spec, pin_idx);
2013-10-05 1250 per_pin->cvt_nid = per_cvt->cvt_nid;
2011-06-01 1251 hinfo->nid = per_cvt->cvt_nid;
2011-06-01 1252
2019-12-02 1253 /* flip stripe flag for the assigned stream if supported */
2019-12-02 1254 if (get_wcaps(codec, per_cvt->cvt_nid) & AC_WCAP_STRIPE)
2019-12-02 1255 azx_stream(get_azx_dev(substream))->stripe = 1;
2019-12-02 1256
2017-01-12 1257 snd_hda_set_dev_select(codec, per_pin->pin_nid, per_pin->dev_id);
2013-06-18 1258 snd_hda_codec_write_cache(codec, per_pin->pin_nid, 0,
2011-06-01 1259 AC_VERB_SET_CONNECT_SEL,
2016-03-21 1260 per_pin->mux_idx);
2013-06-18 1261
2013-06-18 1262 /* configure unused pins to choose other converters */
2016-03-21 1263 pin_cvt_fixup(codec, per_pin, 0);
2013-06-18 1264
2015-12-16 @1265 snd_hda_spdif_ctls_assign(codec, pcm_idx, per_cvt->cvt_nid);
2010-08-13 1266
2011-06-01 1267 /* Initially set the converter's capabilities */
2011-06-01 1268 hinfo->channels_min = per_cvt->channels_min;
2011-06-01 1269 hinfo->channels_max = per_cvt->channels_max;
2011-06-01 1270 hinfo->rates = per_cvt->rates;
2011-06-01 1271 hinfo->formats = per_cvt->formats;
2011-06-01 1272 hinfo->maxbps = per_cvt->maxbps;
2011-06-01 1273
2015-12-16 1274 eld = &per_pin->sink_eld;
2011-06-01 1275 /* Restrict capabilities by ELD if this isn't disabled */
2011-06-01 1276 if (!static_hdmi_pcm && eld->eld_valid) {
Henningsson 2013-02-19 1277 snd_hdmi_eld_update_pcm_info(&eld->info, hinfo);
2010-08-13 1278 if (hinfo->channels_min > hinfo->channels_max ||
2013-02-01 1279 !hinfo->rates || !hinfo->formats) {
2013-02-01 1280 per_cvt->assigned = 0;
2013-02-01 1281 hinfo->nid = 0;
2015-12-16 @1282 snd_hda_spdif_ctls_unassign(codec, pcm_idx);
2018-07-12 1283 err = -ENODEV;
2018-07-12 1284 goto unlock;
2010-08-13 1285 }
2013-02-01 1286 }
2011-06-01 1287
2011-06-01 1288 /* Store the updated parameters */
2011-01-14 1289 runtime->hw.channels_min = hinfo->channels_min;
2011-01-14 1290 runtime->hw.channels_max = hinfo->channels_max;
2011-01-14 1291 runtime->hw.formats = hinfo->formats;
2011-01-14 1292 runtime->hw.rates = hinfo->rates;
2011-01-14 1293
2011-01-14 1294 snd_pcm_hw_constraint_step(substream->runtime, 0,
2011-01-14 1295 SNDRV_PCM_HW_PARAM_CHANNELS, 2);
2018-07-12 1296 unlock:
2018-07-12 1297 mutex_unlock(&spec->pcm_lock);
2018-07-12 1298 return err;
2010-08-13 1299 }
2010-08-13 1300
line 1086 was first introduced by commit
89ca27e4450daefbd89 ALSA: hda - add DP MST audio support
<[email protected]>
<[email protected]>
Open Source Technology Center
rg/hyperkitty/list/kbuild-all@lists.01.org">https://lists.01.org/hyperkitty/list/[email protected] Intel Corporation

Attachments:

(No filename) (33.95 kB)
.config.gz (41.70 kB)
Download all attachments

2020-02-06 13:41:53

by Kai Vehmanen

[permalink] [raw]

Subject: Re: sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'

Hey,

On Thu, 6 Feb 2020, kbuild test robot wrote:

> ld: sound/pci/hda/patch_hdmi.o: in function `intel_not_share_assigned_cvt':
> >> sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'
> >> ld: sound/pci/hda/patch_hdmi.c:1098: undefined reference to `snd_hda_get_dev_select'
> >> ld: sound/pci/hda/patch_hdmi.c:1099: undefined reference to `snd_hda_set_dev_select'

hmm, this seems similar case as the previous one today w.r.t
hda_dsp_common.c:76. Patch_hdmi.c is built-in while snd-hda is a module.
Maybe we need to just drop the dependency from the ASoC board files to
SND_HDA_CODEC_HDMI. We don't have one for SND_HDA_CODEC either.

Br, Kai

2020-02-06 13:49:48

by Takashi Iwai

[permalink] [raw]

Subject: Re: sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'

On Thu, 06 Feb 2020 14:40:17 +0100,
Kai Vehmanen wrote:
>
> Hey,
>
> On Thu, 6 Feb 2020, kbuild test robot wrote:
>
> > ld: sound/pci/hda/patch_hdmi.o: in function `intel_not_share_assigned_cvt':
> > >> sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'
> > >> ld: sound/pci/hda/patch_hdmi.c:1098: undefined reference to `snd_hda_get_dev_select'
> > >> ld: sound/pci/hda/patch_hdmi.c:1099: undefined reference to `snd_hda_set_dev_select'
>
> hmm, this seems similar case as the previous one today w.r.t
> hda_dsp_common.c:76. Patch_hdmi.c is built-in while snd-hda is a module.
> Maybe we need to just drop the dependency from the ASoC board files to
> SND_HDA_CODEC_HDMI. We don't have one for SND_HDA_CODEC either.

The problem is that SOF tries to do reverse-select the legacy HD-audio
codec, but it doesn't work in general. Or it must be done very
carefully.

If something gets selected, all dependencies have to be
reverse-selected, too. But the legacy HDA is built up in a way of
standard top-down selection (i.e. SND_HDA_CODEC_* depends on SND_HDA,
not other way round).

Takashi

2020-02-06 17:08:33

by Pierre-Louis Bossart

[permalink] [raw]

Subject: Re: sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'

On 2/6/20 7:48 AM, Takashi Iwai wrote:
> On Thu, 06 Feb 2020 14:40:17 +0100,
> Kai Vehmanen wrote:
>>
>> Hey,
>>
>> On Thu, 6 Feb 2020, kbuild test robot wrote:
>>
>>> ld: sound/pci/hda/patch_hdmi.o: in function `intel_not_share_assigned_cvt':
>>>>> sound/pci/hda/patch_hdmi.c:1086: undefined reference to `snd_hda_get_num_devices'
>>>>> ld: sound/pci/hda/patch_hdmi.c:1098: undefined reference to `snd_hda_get_dev_select'
>>>>> ld: sound/pci/hda/patch_hdmi.c:1099: undefined reference to `snd_hda_set_dev_select'
>>
>> hmm, this seems similar case as the previous one today w.r.t
>> hda_dsp_common.c:76. Patch_hdmi.c is built-in while snd-hda is a module.
>> Maybe we need to just drop the dependency from the ASoC board files to
>> SND_HDA_CODEC_HDMI. We don't have one for SND_HDA_CODEC either.
>
> The problem is that SOF tries to do reverse-select the legacy HD-audio
> codec, but it doesn't work in general. Or it must be done very
> carefully.
>
> If something gets selected, all dependencies have to be
> reverse-selected, too. But the legacy HDA is built up in a way of
> standard top-down selection (i.e. SND_HDA_CODEC_* depends on SND_HDA,
> not other way round).

It's the same issue as the other one reported earlier, and adding the
dependency on SOF_HDA makes the unmet dependency go away.