2020-02-13 04:33:09

by Yang Shi

Subject: [PATCH] mm: vmscan: replace open codings to NUMA_NO_NODE

The commit 98fa15f34cb3 ("mm: replace all open encodings for
NUMA_NO_NODE") did the replacement across the kernel tree, but we got
some more in vmscan.c since then.

Cc: Minchan Kim <[email protected]>
Cc: Anshuman Khandual <[email protected]>
Signed-off-by: Yang Shi <[email protected]>
---
mm/vmscan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index c05eb9e..567864a 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2096,7 +2096,7 @@ static void shrink_active_list(unsigned long nr_to_scan,

unsigned long reclaim_pages(struct list_head *page_list)
{
- int nid = -1;
+ int nid = NUMA_NO_NODE;
unsigned long nr_reclaimed = 0;
LIST_HEAD(node_page_list);
struct reclaim_stat dummy_stat;
@@ -2111,7 +2111,7 @@ unsigned long reclaim_pages(struct list_head *page_list)

while (!list_empty(page_list)) {
page = lru_to_page(page_list);
- if (nid == -1) {
+ if (nid == NUMA_NO_NODE) {
nid = page_to_nid(page);
INIT_LIST_HEAD(&node_page_list);
}
@@ -2132,7 +2132,7 @@ unsigned long reclaim_pages(struct list_head *page_list)
putback_lru_page(page);
}

- nid = -1;
+ nid = NUMA_NO_NODE;
}

if (!list_empty(&node_page_list)) {
--
1.8.3.1

2020-02-13 17:27:32

by Minchan Kim

Subject: Re: [PATCH] mm: vmscan: replace open codings to NUMA_NO_NODE

On Thu, Feb 13, 2020 at 12:31:38PM +0800, Yang Shi wrote:
> The commit 98fa15f34cb3 ("mm: replace all open encodings for
> NUMA_NO_NODE") did the replacement across the kernel tree, but we got
> some more in vmscan.c since then.
>
> Cc: Minchan Kim <[email protected]>
> Cc: Anshuman Khandual <[email protected]>
> Signed-off-by: Yang Shi <[email protected]>
Acked-by: Minchan Kim <[email protected]>

Thanks, Yang!

2020-02-14 20:28:50

by David Rientjes

Subject: Re: [PATCH] mm: vmscan: replace open codings to NUMA_NO_NODE

On Thu, 13 Feb 2020, Yang Shi wrote:

> The commit 98fa15f34cb3 ("mm: replace all open encodings for
> NUMA_NO_NODE") did the replacement across the kernel tree, but we got
> some more in vmscan.c since then.
>
> Cc: Minchan Kim <[email protected]>
> Cc: Anshuman Khandual <[email protected]>
> Signed-off-by: Yang Shi <[email protected]>

Acked-by: David Rientjes <[email protected]>

2020-02-15 04:59:16

by Anshuman Khandual

Subject: Re: [PATCH] mm: vmscan: replace open codings to NUMA_NO_NODE

On 02/13/2020 10:01 AM, Yang Shi wrote:
> The commit 98fa15f34cb3 ("mm: replace all open encodings for
> NUMA_NO_NODE") did the replacement across the kernel tree, but we got
> some more in vmscan.c since then.
>
> Cc: Minchan Kim <[email protected]>
> Cc: Anshuman Khandual <[email protected]>
> Signed-off-by: Yang Shi <[email protected]>

Reviewed-by: Anshuman Khandual <[email protected]>