2020-03-28 15:28:29

by Marcelo Tosatti

[permalink] [raw]
Subject: [patch 3/3] isolcpus: undeprecate on documentation

isolcpus is used to control steering of interrupts to managed_irqs and
kernel threads, therefore its incorrect to state that its deprecated.

Remove deprecation warning.

Suggested-by: Chris Friesen <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>

---
Documentation/admin-guide/kernel-parameters.txt | 1 -
1 file changed, 1 deletion(-)

Index: linux-2.6/Documentation/admin-guide/kernel-parameters.txt
===================================================================
--- linux-2.6.orig/Documentation/admin-guide/kernel-parameters.txt
+++ linux-2.6/Documentation/admin-guide/kernel-parameters.txt
@@ -1926,7 +1926,6 @@
Format: <RDP>,<reset>,<pci_scan>,<verbosity>

isolcpus= [KNL,SMP,ISOL] Isolate a given set of CPUs from disturbance.
- [Deprecated - use cpusets instead]
Format: [flag-list,]<cpu-list>

Specify one or more CPUs to isolate from disturbances



2020-03-31 15:23:26

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [patch 3/3] isolcpus: undeprecate on documentation

On Sat, Mar 28, 2020 at 12:21:20PM -0300, Marcelo Tosatti wrote:
> isolcpus is used to control steering of interrupts to managed_irqs and
> kernel threads, therefore its incorrect to state that its deprecated.
>
> Remove deprecation warning.
>
> Suggested-by: Chris Friesen <[email protected]>
> Signed-off-by: Marcelo Tosatti <[email protected]>
>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> ===================================================================
> --- linux-2.6.orig/Documentation/admin-guide/kernel-parameters.txt
> +++ linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> @@ -1926,7 +1926,6 @@
> Format: <RDP>,<reset>,<pci_scan>,<verbosity>
>
> isolcpus= [KNL,SMP,ISOL] Isolate a given set of CPUs from disturbance.
> - [Deprecated - use cpusets instead]
> Format: [flag-list,]<cpu-list>
>

It's still an absolute horrible piece of crap though. nozh_full piling
more and more shit on it doesn't make it more shiny.

2020-03-31 15:42:51

by Marcelo Tosatti

[permalink] [raw]
Subject: Re: [patch 3/3] isolcpus: undeprecate on documentation

On Tue, Mar 31, 2020 at 05:22:17PM +0200, Peter Zijlstra wrote:
> On Sat, Mar 28, 2020 at 12:21:20PM -0300, Marcelo Tosatti wrote:
> > isolcpus is used to control steering of interrupts to managed_irqs and
> > kernel threads, therefore its incorrect to state that its deprecated.
> >
> > Remove deprecation warning.
> >
> > Suggested-by: Chris Friesen <[email protected]>
> > Signed-off-by: Marcelo Tosatti <[email protected]>
> >
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > Index: linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> > ===================================================================
> > --- linux-2.6.orig/Documentation/admin-guide/kernel-parameters.txt
> > +++ linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> > @@ -1926,7 +1926,6 @@
> > Format: <RDP>,<reset>,<pci_scan>,<verbosity>
> >
> > isolcpus= [KNL,SMP,ISOL] Isolate a given set of CPUs from disturbance.
> > - [Deprecated - use cpusets instead]
> > Format: [flag-list,]<cpu-list>
> >
>
> It's still an absolute horrible piece of crap though. nozh_full piling
> more and more shit on it doesn't make it more shiny.

Hi Peter,

Why do you dislike it? What you think would be a decent approach?

2020-03-31 15:44:17

by Frederic Weisbecker

[permalink] [raw]
Subject: Re: [patch 3/3] isolcpus: undeprecate on documentation

On Tue, Mar 31, 2020 at 05:22:17PM +0200, Peter Zijlstra wrote:
> On Sat, Mar 28, 2020 at 12:21:20PM -0300, Marcelo Tosatti wrote:
> > isolcpus is used to control steering of interrupts to managed_irqs and
> > kernel threads, therefore its incorrect to state that its deprecated.
> >
> > Remove deprecation warning.
> >
> > Suggested-by: Chris Friesen <[email protected]>
> > Signed-off-by: Marcelo Tosatti <[email protected]>
> >
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > Index: linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> > ===================================================================
> > --- linux-2.6.orig/Documentation/admin-guide/kernel-parameters.txt
> > +++ linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> > @@ -1926,7 +1926,6 @@
> > Format: <RDP>,<reset>,<pci_scan>,<verbosity>
> >
> > isolcpus= [KNL,SMP,ISOL] Isolate a given set of CPUs from disturbance.
> > - [Deprecated - use cpusets instead]
> > Format: [flag-list,]<cpu-list>
> >
>
> It's still an absolute horrible piece of crap though. nozh_full piling
> more and more shit on it doesn't make it more shiny.

Right. I still plan to propagate it to the cpuset mountpoints at some future
so that this becomes mutable.

2020-03-31 15:58:07

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [patch 3/3] isolcpus: undeprecate on documentation

On Tue, Mar 31, 2020 at 12:41:46PM -0300, Marcelo Tosatti wrote:
> On Tue, Mar 31, 2020 at 05:22:17PM +0200, Peter Zijlstra wrote:
> > On Sat, Mar 28, 2020 at 12:21:20PM -0300, Marcelo Tosatti wrote:
> > > isolcpus is used to control steering of interrupts to managed_irqs and
> > > kernel threads, therefore its incorrect to state that its deprecated.
> > >
> > > Remove deprecation warning.
> > >
> > > Suggested-by: Chris Friesen <[email protected]>
> > > Signed-off-by: Marcelo Tosatti <[email protected]>
> > >
> > > ---
> > > Documentation/admin-guide/kernel-parameters.txt | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > Index: linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> > > ===================================================================
> > > --- linux-2.6.orig/Documentation/admin-guide/kernel-parameters.txt
> > > +++ linux-2.6/Documentation/admin-guide/kernel-parameters.txt
> > > @@ -1926,7 +1926,6 @@
> > > Format: <RDP>,<reset>,<pci_scan>,<verbosity>
> > >
> > > isolcpus= [KNL,SMP,ISOL] Isolate a given set of CPUs from disturbance.
> > > - [Deprecated - use cpusets instead]
> > > Format: [flag-list,]<cpu-list>
> > >
> >
> > It's still an absolute horrible piece of crap though. nozh_full piling
> > more and more shit on it doesn't make it more shiny.
>
> Hi Peter,
>
> Why do you dislike it? What you think would be a decent approach?

Try and reconfigure it after boot.

Subject: Re: [patch 3/3] isolcpus: undeprecate on documentation

On Tue, 31 Mar 2020, Peter Zijlstra wrote:

> > Why do you dislike it? What you think would be a decent approach?
>
> Try and reconfigure it after boot.

Not really a problem since this is not the only issue that requires a
reboot.

You have to reboot most of the time if you change applications on a HPC
machine. After all you cannot reliably change the available set of huge
pages after boot. So you have to reboot anyways if you want some cores to
do different things.

And then the machines performance goes down over time due to
memory fragmentation. So you better reboot frequently.

Thus reboot, reboot, reboot. We have become like Windows 95 ...