Hi,
In the course of looking into Christoph's recent proposal to drop legacy
IDE drivers I have noticed that SiByte SWARM's defconfig does not enable
the pata_platform driver for the onboard PATA interface. I think default
configuration ought to enable all the supported onboard devices unless
there are specific reasons so as not to, and the PATA interface is one of
the boot devices supported by the CFE firmware, so I think even more then
that it should be included by default.
Change split into two because the defconfig has become stale since the
last update, so 1/2 first regenerates it, and then 2/2 applies the actual
modification.
Sadly I'm currently away from my SWARM board for the foreseeable future
and I have no remote access to it either, but this is supposed not to need
run-time verification. Build-tested only then.
Please apply.
Maciej
Options have been removed and reordered since the last update, so
regenerate the template so as not to interfere with actual changes.
Signed-off-by: Maciej W. Rozycki <[email protected]>
---
arch/mips/configs/sb1250_swarm_defconfig | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
linux-swarm-defconfig-regen.diff
Index: linux-swarm-defconfig/arch/mips/configs/sb1250_swarm_defconfig
===================================================================
--- linux-swarm-defconfig.orig/arch/mips/configs/sb1250_swarm_defconfig
+++ linux-swarm-defconfig/arch/mips/configs/sb1250_swarm_defconfig
@@ -17,7 +17,6 @@ CONFIG_64BIT=y
CONFIG_SMP=y
CONFIG_NR_CPUS=2
CONFIG_HZ_1000=y
-CONFIG_PCI=y
CONFIG_MIPS32_O32=y
CONFIG_PM=y
CONFIG_MODULES=y
@@ -34,15 +33,13 @@ CONFIG_INET=y
CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
CONFIG_IP_PNP_BOOTP=y
-CONFIG_INET_XFRM_MODE_TRANSPORT=m
-CONFIG_INET_XFRM_MODE_TUNNEL=m
-CONFIG_INET_XFRM_MODE_BEET=m
CONFIG_TCP_MD5SIG=y
# CONFIG_IPV6 is not set
CONFIG_NETWORK_SECMARK=y
CONFIG_CFG80211=m
CONFIG_MAC80211=m
CONFIG_RFKILL=m
+CONFIG_PCI=y
CONFIG_FW_LOADER=m
CONFIG_CONNECTOR=m
CONFIG_BLK_DEV_RAM=y
@@ -88,18 +85,14 @@ CONFIG_CRYPTO_MICHAEL_MIC=m
CONFIG_CRYPTO_SHA512=m
CONFIG_CRYPTO_TGR192=m
CONFIG_CRYPTO_WP512=m
-CONFIG_CRYPTO_ANUBIS=m
CONFIG_CRYPTO_BLOWFISH=m
CONFIG_CRYPTO_CAMELLIA=m
CONFIG_CRYPTO_CAST5=m
CONFIG_CRYPTO_CAST6=m
CONFIG_CRYPTO_DES=m
CONFIG_CRYPTO_FCRYPT=m
-CONFIG_CRYPTO_KHAZAD=m
CONFIG_CRYPTO_SALSA20=m
-CONFIG_CRYPTO_SEED=m
CONFIG_CRYPTO_SERPENT=m
-CONFIG_CRYPTO_TEA=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_DEFLATE=m
CONFIG_CRYPTO_LZO=m
Enable support for the onboard PATA PIO mode3 interface, which is one of
the boot devices supported by the CFE firmware with the Broadcom SWARM
board. Include disk, CD-ROM and generic storage drivers.
Signed-off-by: Maciej W. Rozycki <[email protected]>
---
arch/mips/configs/sb1250_swarm_defconfig | 8 ++++++++
1 file changed, 8 insertions(+)
linux-pata-swarm-defconfig.diff
Index: linux-swarm-defconfig/arch/mips/configs/sb1250_swarm_defconfig
===================================================================
--- linux-swarm-defconfig.orig/arch/mips/configs/sb1250_swarm_defconfig
+++ linux-swarm-defconfig/arch/mips/configs/sb1250_swarm_defconfig
@@ -50,6 +50,14 @@ CONFIG_IDE=y
CONFIG_BLK_DEV_IDECD=y
CONFIG_BLK_DEV_IDETAPE=y
CONFIG_RAID_ATTRS=m
+CONFIG_BLK_DEV_SD=y
+CONFIG_BLK_DEV_SR=y
+CONFIG_CHR_DEV_SG=y
+CONFIG_SCSI_CONSTANTS=y
+# CONFIG_SCSI_LOWLEVEL is not set
+CONFIG_ATA=y
+# CONFIG_ATA_BMDMA is not set
+CONFIG_PATA_PLATFORM=y
CONFIG_NETDEVICES=y
CONFIG_MACVLAN=m
CONFIG_SB1250_MAC=y
On Sun, Mar 21, 2021 at 08:55:37PM +0100, Maciej W. Rozycki wrote:
> Hi,
>
> In the course of looking into Christoph's recent proposal to drop legacy
> IDE drivers I have noticed that SiByte SWARM's defconfig does not enable
> the pata_platform driver for the onboard PATA interface. I think default
> configuration ought to enable all the supported onboard devices unless
> there are specific reasons so as not to, and the PATA interface is one of
> the boot devices supported by the CFE firmware, so I think even more then
> that it should be included by default.
>
> Change split into two because the defconfig has become stale since the
> last update, so 1/2 first regenerates it, and then 2/2 applies the actual
> modification.
>
> Sadly I'm currently away from my SWARM board for the foreseeable future
> and I have no remote access to it either, but this is supposed not to need
> run-time verification. Build-tested only then.
>
> Please apply.
series applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]