2022-11-16 21:40:15

by Maciej W. Rozycki

[permalink] [raw]
Subject: [PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

Decrease the number of PCI BAR pair slots allocated for port subdrivers
from 4 to 2 as none wants more than 2 at this time, reducing the memory
footprint a little. No functional change.

Signed-off-by: Maciej W. Rozycki <[email protected]>
---
drivers/parport/parport_pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

linux-parport-pc-pci-bars.diff
Index: linux-macro/drivers/parport/parport_pc.c
===================================================================
--- linux-macro.orig/drivers/parport/parport_pc.c
+++ linux-macro/drivers/parport/parport_pc.c
@@ -2657,7 +2657,7 @@ static struct parport_pc_pci {
int lo;
int hi;
/* -1 if not there, >6 for offset-method (max BAR is 6) */
- } addr[4];
+ } addr[2];

/* Bit field of parport modes to exclude. */
unsigned int mode_mask;


2023-01-06 01:31:15

by Maciej W. Rozycki

[permalink] [raw]
Subject: [PATCH][PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

On Wed, 16 Nov 2022, Maciej W. Rozycki wrote:

> Decrease the number of PCI BAR pair slots allocated for port subdrivers
> from 4 to 2 as none wants more than 2 at this time, reducing the memory
> footprint a little. No functional change.

Ping for:
<https://lore.kernel.org/lkml/[email protected]/>.

Maciej

2023-01-07 15:12:07

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH][PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

On Fri, 6 Jan 2023 at 01:12, Maciej W. Rozycki <[email protected]> wrote:
>
> On Wed, 16 Nov 2022, Maciej W. Rozycki wrote:
>
> > Decrease the number of PCI BAR pair slots allocated for port subdrivers
> > from 4 to 2 as none wants more than 2 at this time, reducing the memory
> > footprint a little. No functional change.
>
> Ping for:
> <https://lore.kernel.org/lkml/[email protected]/>.

Sorry for the delay. Had to dig out my hardwares for the other series.
This and the other series
looks ok. Will test tonight and I will send it to Greg.


--
Regards
Sudip

2023-01-08 15:28:19

by Maciej W. Rozycki

[permalink] [raw]
Subject: Re: [PATCH][PATCH] parport_pc: Limit the number of PCI BAR pairs to 2

On Sat, 7 Jan 2023, Sudip Mukherjee wrote:

> > > Decrease the number of PCI BAR pair slots allocated for port subdrivers
> > > from 4 to 2 as none wants more than 2 at this time, reducing the memory
> > > footprint a little. No functional change.
> >
> > Ping for:
> > <https://lore.kernel.org/lkml/[email protected]/>.
>
> Sorry for the delay. Had to dig out my hardwares for the other series.
> This and the other series
> looks ok. Will test tonight and I will send it to Greg.

No worries, and thank you for your review!

Maciej