2023-06-01 13:14:15

by Maciej W. Rozycki

Subject: [PATCH 0/2] MIPS: Fix recent clutter with PATA_PLATFORM

Hi,

A recent change has cluttered irrelevant MIPS platforms such as MALTA
with PATA_PLATFORM configuration question, which makes no sense for them.
This small patch series addresses the original issue in the correct way.

See individual change descriptions for details. Please apply.

Maciej

2023-06-01 13:20:00

by Maciej W. Rozycki

Subject: [PATCH 2/2] Revert "MIPS: unhide PATA_PLATFORM"

Revert commit 75b18aac6fa3 ("MIPS: unhide PATA_PLATFORM") now that
HAVE_PATA_PLATFORM is set selectively for all the relevant platforms.

Verified with `db1xxx_defconfig' and `sb1250_swarm_defconfig' by making
sure PATA_PLATFORM is still there in `.config' with this change applied,
and with `malta_defconfig' by making sure it's now gone.

Signed-off-by: Maciej W. Rozycki <[email protected]>
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)

linux-mips-no-pata-platform.diff
Index: linux-macro/arch/mips/Kconfig
===================================================================
--- linux-macro.orig/arch/mips/Kconfig
+++ linux-macro/arch/mips/Kconfig
@@ -79,7 +79,6 @@ config MIPS
select HAVE_LD_DEAD_CODE_DATA_ELIMINATION
select HAVE_MOD_ARCH_SPECIFIC
select HAVE_NMI
- select HAVE_PATA_PLATFORM
select HAVE_PERF_EVENTS
select HAVE_PERF_REGS
select HAVE_PERF_USER_STACK_DUMP

2023-06-09 08:46:45

by Thomas Bogendoerfer

Subject: Re: [PATCH 2/2] Revert "MIPS: unhide PATA_PLATFORM"

On Thu, Jun 01, 2023 at 01:56:36PM +0100, Maciej W. Rozycki wrote:
> Revert commit 75b18aac6fa3 ("MIPS: unhide PATA_PLATFORM") now that
> HAVE_PATA_PLATFORM is set selectively for all the relevant platforms.
>
> Verified with `db1xxx_defconfig' and `sb1250_swarm_defconfig' by making
> sure PATA_PLATFORM is still there in `.config' with this change applied,
> and with `malta_defconfig' by making sure it's now gone.
>
> Signed-off-by: Maciej W. Rozycki <[email protected]>
> ---
> arch/mips/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> linux-mips-no-pata-platform.diff
> Index: linux-macro/arch/mips/Kconfig
> ===================================================================
> --- linux-macro.orig/arch/mips/Kconfig
> +++ linux-macro/arch/mips/Kconfig
> @@ -79,7 +79,6 @@ config MIPS
> select HAVE_LD_DEAD_CODE_DATA_ELIMINATION
> select HAVE_MOD_ARCH_SPECIFIC
> select HAVE_NMI
> - select HAVE_PATA_PLATFORM
> select HAVE_PERF_EVENTS
> select HAVE_PERF_REGS
> select HAVE_PERF_USER_STACK_DUMP

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]