2023-08-14 10:04:19

by Tiezhu Yang

Subject: [PATCH v3 3/3] MIPS: Modify the declaration for die()

While at it, modify the die() declaration in ptrace.h to fix
the following checkpatch warnings:

WARNING: function definition argument 'const char *' should also have an identifier name
WARNING: function definition argument 'struct pt_regs *' should also have an identifier name

Signed-off-by: Tiezhu Yang <[email protected]>
---
arch/mips/include/asm/ptrace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
index aee8e0a..d05844e 100644
--- a/arch/mips/include/asm/ptrace.h
+++ b/arch/mips/include/asm/ptrace.h
@@ -159,7 +159,7 @@ static inline long regs_return_value(struct pt_regs *regs)
extern asmlinkage long syscall_trace_enter(struct pt_regs *regs, long syscall);
extern asmlinkage void syscall_trace_leave(struct pt_regs *regs);

-extern void die(const char *, struct pt_regs *);
+extern void die(const char *str, struct pt_regs *regs);

static inline void die_if_kernel(const char *str, struct pt_regs *regs)
{
--
2.1.0

2023-08-19 10:56:45

by Maciej W. Rozycki

Subject: Re: [PATCH v3 3/3] MIPS: Modify the declaration for die()

On Mon, 14 Aug 2023, Tiezhu Yang wrote:

> While at it, modify the die() declaration in ptrace.h to fix
> the following checkpatch warnings:

It doesn't make sense to say: "While at it" now that it's a separate
change, so how about:

"
Modify the die() declaration in ptrace.h to fix the following checkpatch
warnings:
"

?

Maciej