2020-08-04 02:36:14

by Sumera Priyadarsini

Subject: [PATCH] scripts: coccicheck: Add chain mode to list of modes

This patch adds chain mode to the list of available modes in coccinelle.

Signed-off-by: Sumera Priyadarsini <[email protected]>
---
scripts/coccicheck | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328210ac..6e37cf36caae 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -99,7 +99,7 @@ fi
if [ "$MODE" = "" ] ; then
if [ "$ONLINE" = "0" ] ; then
echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
- echo 'Available modes are the following: patch, report, context, org'
+ echo 'Available modes are the following: patch, report, context, org, chain'
echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
echo 'Note however that some modes are not implemented by some semantic patches.'
fi
--
2.17.1

2020-08-04 20:42:05

by Julia Lawall

Subject: Re: [Cocci] [PATCH] scripts: coccicheck: Add chain mode to list of modes

On Tue, 4 Aug 2020, Sumera Priyadarsini wrote:

> This patch adds chain mode to the list of available modes in coccinelle.

Thanks for the commit. In the log message, could you change "coccinelle"
o "coccicheck"? Actually, the modes are not something that are built into
Coccinelle. They are just implemented by the coccicheck script.

thanks,
julia


>
> Signed-off-by: Sumera Priyadarsini <[email protected]>
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index e04d328210ac..6e37cf36caae 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -99,7 +99,7 @@ fi
> if [ "$MODE" = "" ] ; then
> if [ "$ONLINE" = "0" ] ; then
> echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
> - echo 'Available modes are the following: patch, report, context, org'
> + echo 'Available modes are the following: patch, report, context, org, chain'
> echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
> echo 'Note however that some modes are not implemented by some semantic patches.'
> fi
> --
> 2.17.1
>
> _______________________________________________
> Cocci mailing list
> [email protected]
> https://systeme.lip6.fr/mailman/listinfo/cocci
>