2020-10-22 17:16:10

by Izabela Bakollari

Subject: [PATCH] staging/wlan-ng: Fix line that exceeds 100 columns

From: Izabela Bakollari <[email protected]>

Rearrange comment that exceeds 100 columns length. Issue reported
by checkpatch.pl

Signed-off-by: Izabela Bakollari <[email protected]>
---
drivers/staging/wlan-ng/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 759e475e303c..5fad37a49aa5 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -366,7 +366,8 @@ static int prism2_scan(struct wiphy *wiphy,
msg2.beaconperiod.data,
ie_buf,
ie_len,
- (msg2.signal.data - 65536) * 100, /* Conversion to signed type */
+ (msg2.signal.data - 65536) * 100,
+ /* Conversion to signed type */
GFP_KERNEL);

if (!bss) {
--
2.18.4

2020-10-22 17:29:04

by Julia Lawall

Subject: Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line that exceeds 100 columns

On Thu, 22 Oct 2020, [email protected] wrote:

> From: Izabela Bakollari <[email protected]>
>
> Rearrange comment that exceeds 100 columns length. Issue reported
> by checkpatch.pl
>
> Signed-off-by: Izabela Bakollari <[email protected]>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 759e475e303c..5fad37a49aa5 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -366,7 +366,8 @@ static int prism2_scan(struct wiphy *wiphy,
> msg2.beaconperiod.data,
> ie_buf,
> ie_len,
> - (msg2.signal.data - 65536) * 100, /* Conversion to signed type */
> + (msg2.signal.data - 65536) * 100,
> + /* Conversion to signed type */

I think that the comment is in the wrong place. GFP_KERNEL has to do with
whether the allocation can wait in case of insufficient memory, and not
with signed types. The signed type thing must be the argument before. Si
it would be better to put the comment above that code.

julia


> GFP_KERNEL);
>
> if (!bss) {
> --
> 2.18.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201022130807.212454-1-izabela.bakollari%40gmail.com.
>