2021-12-03 09:44:47

by Julia Lawall

Subject: [PATCH] net: prestera: fix flexible_array.cocci warnings

From: kernel test robot <[email protected]>

Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes: 6e36c7bcb461 ("net: prestera: add counter HW API")
CC: Volodymyr Mytnyk <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 9606f9efb1cec7f8f5912326f182fbfbcad34382
commit: 6e36c7bcb4611414b339173cdc33fdcb55c08f9e [4129/4921] net: prestera: add counter HW API
:::::: branch date: 19 hours ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

prestera_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/marvell/prestera/prestera_hw.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.c
@@ -443,7 +443,7 @@ struct prestera_msg_counter_resp {
__le32 offset;
__le32 num_counters;
__le32 done;
- struct prestera_msg_counter_stats stats[0];
+ struct prestera_msg_counter_stats stats[];
};

struct prestera_msg_span_req {

2021-12-04 17:45:55

by Volodymyr Mytnyk

Subject: Re: [PATCH] net: prestera: fix flexible_array.cocci warnings

> Subject: [PATCH] net: prestera: fix flexible_array.cocci warnings
>
> From: kernel test robot <[email protected]>
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>
> Fixes: 6e36c7bcb461 ("net: prestera: add counter HW API")
> CC: Volodymyr Mytnyk <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>
> Signed-off-by: Julia Lawall <[email protected]>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 9606f9efb1cec7f8f5912326f182fbfbcad34382
> commit: 6e36c7bcb4611414b339173cdc33fdcb55c08f9e [4129/4921] net: prestera: add counter HW API
> :::::: branch date: 19 hours ago
> :::::: commit date: 3 days ago
>
> Please take the patch only if it's a positive warning. Thanks!
>
> prestera_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/ethernet/marvell/prestera/prestera_hw.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.c
> @@ -443,7 +443,7 @@ struct prestera_msg_counter_resp {
> __le32 offset;
> __le32 num_counters;
> __le32 done;
> - struct prestera_msg_counter_stats stats[0];
> + struct prestera_msg_counter_stats stats[];
> };
>
> struct prestera_msg_span_req {

Hi Julia,

Fixed in https://www.spinics.net/lists/kernel/msg4167402.html

Thanks and Regards,
Volodymyr