2022-11-14 14:30:33

by Jürgen Groß

Subject: [PATCH] xen/platform-pci: use define instead of literal number

Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from
the interface header in get_callback_via().

Signed-off-by: Juergen Gross <[email protected]>
---
drivers/xen/platform-pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 18f0ed8b1f93..24a3de1b7b03 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev)
pin = pdev->pin;

/* We don't know the GSI. Specify the PCI INTx line instead. */
- return ((uint64_t)0x01 << HVM_CALLBACK_VIA_TYPE_SHIFT) | /* PCI INTx identifier */
+ return ((uint64_t)HVM_PARAM_CALLBACK_TYPE_PCI_INTX <<
+ HVM_CALLBACK_VIA_TYPE_SHIFT) |
((uint64_t)pci_domain_nr(pdev->bus) << 32) |
((uint64_t)pdev->bus->number << 16) |
((uint64_t)(pdev->devfn & 0xff) << 8) |
--
2.35.3

2022-11-14 22:05:42

by Stefano Stabellini

Subject: Re: [PATCH] xen/platform-pci: use define instead of literal number

On Mon, 14 Nov 2022, Juergen Gross wrote:
> Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from
> the interface header in get_callback_via().
>
> Signed-off-by: Juergen Gross <[email protected]>

Acked-by: Stefano Stabellini <[email protected]>


> ---
> drivers/xen/platform-pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
> index 18f0ed8b1f93..24a3de1b7b03 100644
> --- a/drivers/xen/platform-pci.c
> +++ b/drivers/xen/platform-pci.c
> @@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev)
> pin = pdev->pin;
>
> /* We don't know the GSI. Specify the PCI INTx line instead. */
> - return ((uint64_t)0x01 << HVM_CALLBACK_VIA_TYPE_SHIFT) | /* PCI INTx identifier */
> + return ((uint64_t)HVM_PARAM_CALLBACK_TYPE_PCI_INTX <<
> + HVM_CALLBACK_VIA_TYPE_SHIFT) |
> ((uint64_t)pci_domain_nr(pdev->bus) << 32) |
> ((uint64_t)pdev->bus->number << 16) |
> ((uint64_t)(pdev->devfn & 0xff) << 8) |
> --
> 2.35.3
>