2024-03-13 05:24:38

by Ayush Tiwari

Subject: [PATCH] staging: rtl8712: renaming tempVal to temp_val

Renaming variable tempVal to temp_val to address
checkpath warning 'Avoid Camelcase' and to
ensure adherence to coding style guidelines

Signed-off-by: Ayush Tiwari <[email protected]>
---
drivers/staging/rtl8712/rtl8712_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index a3c4713c59b3..7fb9dfaa7448 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -861,7 +861,7 @@ static void query_rx_phy_status(struct _adapter *padapter,
static void process_link_qual(struct _adapter *padapter,
union recv_frame *prframe)
{
- u32 last_evm = 0, tmpVal;
+ u32 last_evm = 0, tmp_val;
struct rx_pkt_attrib *pattrib;
struct smooth_rssi_data *sqd = &padapter->recvpriv.signal_qual_data;

--
2.40.1

2024-03-13 05:47:27

by Dan Carpenter

Subject: Re: [PATCH] staging: rtl8712: renaming tempVal to temp_val

On Wed, Mar 13, 2024 at 10:54:24AM +0530, Ayush Tiwari wrote:
> Renaming variable tempVal to temp_val to address
> checkpath warning 'Avoid Camelcase' and to
> ensure adherence to coding style guidelines

The end of the line is at 72-75 characters. s/Renaming/Rename/. Put a
period on the end of the sentence.

Rename variable tempVal to temp_val to address checkpath warning 'Avoid
Camelcase' and to ensure adherence to coding style guidelines.


>
> Signed-off-by: Ayush Tiwari <[email protected]>
> ---

This will break the build.

regards,
dan carpenter

2024-03-13 06:44:56

by Julia Lawall

Subject: Re: [PATCH] staging: rtl8712: renaming tempVal to temp_val

On Wed, 13 Mar 2024, Ayush Tiwari wrote:

> Renaming variable tempVal to temp_val to address
> checkpath warning 'Avoid Camelcase' and to

Also, it's checkpatch, not checkpath. And it should be "to address the
checkpatch warning".

julia

> ensure adherence to coding style guidelines
>
> Signed-off-by: Ayush Tiwari <[email protected]>
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index a3c4713c59b3..7fb9dfaa7448 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -861,7 +861,7 @@ static void query_rx_phy_status(struct _adapter *padapter,
> static void process_link_qual(struct _adapter *padapter,
> union recv_frame *prframe)
> {
> - u32 last_evm = 0, tmpVal;
> + u32 last_evm = 0, tmp_val;
> struct rx_pkt_attrib *pattrib;
> struct smooth_rssi_data *sqd = &padapter->recvpriv.signal_qual_data;
>
> --
> 2.40.1
>
>
>