2007-09-18 14:54:43

by Rene Herman

[permalink] [raw]
Subject: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index f0cbcdb..670dd49 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
if (val & UCB_ADC_DAT_VALID)
break;
/* yield to other processes */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(1);
+ schedule_timeout_uninterruptible(1);
}

return UCB_ADC_DAT_VALUE(val);

Attachments:
schedule_timeout-ucb1400_ts.diff (530.00 B)

2007-09-18 16:03:52

by Nicolas Pitre

[permalink] [raw]
Subject: Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

On Tue, 18 Sep 2007, Rene Herman wrote:

> Hi Nicolas.
>
> Given that it's not checking for signals, I believe this one should be an
> uninterruptible sleep instead?

Probably.


Nicolas

2007-09-18 17:29:22

by Rene Herman

[permalink] [raw]
Subject: Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

On 09/18/2007 06:03 PM, Nicolas Pitre wrote:

> On Tue, 18 Sep 2007, Rene Herman wrote:
>
>> Hi Nicolas.
>>
>> Given that it's not checking for signals, I believe this one should be an
>> uninterruptible sleep instead?
>
> Probably.

Thanks. Should I send it somewhere or will you or Dmitry grab it?

Rene.

2007-09-18 17:38:50

by Nicolas Pitre

[permalink] [raw]
Subject: Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

On Tue, 18 Sep 2007, Rene Herman wrote:

> On 09/18/2007 06:03 PM, Nicolas Pitre wrote:
>
> > On Tue, 18 Sep 2007, Rene Herman wrote:
> >
> > > Hi Nicolas.
> > >
> > > Given that it's not checking for signals, I believe this one should be an
> > > uninterruptible sleep instead?
> >
> > Probably.
>
> Thanks. Should I send it somewhere or will you or Dmitry grab it?

Please send it to Dmitry with my ACK.


Nicolas

2007-09-18 19:12:01

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

On 9/18/07, Nicolas Pitre <[email protected]> wrote:
> On Tue, 18 Sep 2007, Rene Herman wrote:
>
> > On 09/18/2007 06:03 PM, Nicolas Pitre wrote:
> >
> > > On Tue, 18 Sep 2007, Rene Herman wrote:
> > >
> > > > Hi Nicolas.
> > > >
> > > > Given that it's not checking for signals, I believe this one should be an
> > > > uninterruptible sleep instead?
> > >
> > > Probably.
> >
> > Thanks. Should I send it somewhere or will you or Dmitry grab it?
>
> Please send it to Dmitry with my ACK.
>

I have it, thanks.

Next time please use my gmail or mail.ru account -
[email protected] is dead.

--
Dmitry